Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 862023002: Fix crash on NULL pointer when the browser is compiled with use_cups=0 (Closed)

Created:
5 years, 11 months ago by Paweł Hajdan Jr.
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash on NULL pointer when the browser is compiled with use_cups=0 Please see https://bugs.gentoo.org/show_bug.cgi?id=530682 for context. The idea is to make cups dependency optional at compile time. Even without cups one can print to file (pdf) or use cloud print. BUG=none R=thestig@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/57e9761e4828e1a41af2766c09c700017aa75ba1

Patch Set 1 #

Patch Set 2 : private dtor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3 lines) Patch
M printing/backend/print_backend.h View 1 chunk +0 lines, -1 line 0 comments Download
M printing/backend/print_backend_dummy.cc View 1 1 chunk +41 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Paweł Hajdan Jr.
5 years, 11 months ago (2015-01-21 11:09:28 UTC) #2
Lei Zhang
lgtm Have you tried this to see how printing behaves without cups? There's both print ...
5 years, 11 months ago (2015-01-21 21:20:01 UTC) #3
Paweł Hajdan Jr.
On 2015/01/21 21:20:01, Lei Zhang wrote: > lgtm > > Have you tried this to ...
5 years, 11 months ago (2015-01-22 09:48:37 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/57e9761e4828e1a41af2766c09c700017aa75ba1 Cr-Commit-Position: refs/heads/master@{#312594}
5 years, 11 months ago (2015-01-22 09:51:58 UTC) #5
Paweł Hajdan Jr.
5 years, 11 months ago (2015-01-22 09:52:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
57e9761e4828e1a41af2766c09c700017aa75ba1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698