Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: printing/backend/print_backend_dummy.cc

Issue 862023002: Fix crash on NULL pointer when the browser is compiled with use_cups=0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: private dtor Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « printing/backend/print_backend.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/backend/print_backend_dummy.cc
diff --git a/printing/backend/print_backend_dummy.cc b/printing/backend/print_backend_dummy.cc
index c73e5370720eda7a2f989401f37dc62c5e438e24..db269a75920d3c44381c87d67b91d923f0bfd8dc 100644
--- a/printing/backend/print_backend_dummy.cc
+++ b/printing/backend/print_backend_dummy.cc
@@ -13,10 +13,49 @@
namespace printing {
+class DummyPrintBackend : public PrintBackend {
+ public:
+ DummyPrintBackend() {
+ }
+
+ bool EnumeratePrinters(PrinterList* printer_list) override {
+ return false;
+ }
+
+ std::string GetDefaultPrinterName() override {
+ return std::string();
+ }
+
+ bool GetPrinterSemanticCapsAndDefaults(
+ const std::string& printer_name,
+ PrinterSemanticCapsAndDefaults* printer_info) override {
+ return false;
+ }
+
+ bool GetPrinterCapsAndDefaults(
+ const std::string& printer_name,
+ PrinterCapsAndDefaults* printer_info) override {
+ return false;
+ }
+
+ std::string GetPrinterDriverInfo(
+ const std::string& printer_name) override {
+ return std::string();
+ }
+
+ bool IsValidPrinter(const std::string& printer_name) override {
+ return false;
+ }
+
+ private:
+ ~DummyPrintBackend() {}
+
+ DISALLOW_COPY_AND_ASSIGN(DummyPrintBackend);
+};
+
scoped_refptr<PrintBackend> PrintBackend::CreateInstance(
const base::DictionaryValue* print_backend_settings) {
- NOTREACHED();
- return NULL;
+ return new DummyPrintBackend();
}
} // namespace printing
« no previous file with comments | « printing/backend/print_backend.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698