Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4024)

Unified Diff: chrome/android/java/res/layout/account_chooser_infobar_list.xml

Issue 861103002: Credentials chooser UI for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Please review. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/account_chooser_infobar_list.xml
diff --git a/chrome/android/java/res/layout/account_chooser_infobar_list.xml b/chrome/android/java/res/layout/account_chooser_infobar_list.xml
new file mode 100644
index 0000000000000000000000000000000000000000..0f11adb94dc17a2c474e1b7b0991ef2c8077784d
--- /dev/null
+++ b/chrome/android/java/res/layout/account_chooser_infobar_list.xml
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2015 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+<FrameLayout
newt (away) 2015/02/19 21:49:27 It's OK to keep this FrameLayout. We could fix Inf
melandory 2015/02/19 22:36:50 Acknowledged.
+ xmlns:android="http://schemas.android.com/apk/res/android"
+ android:layout_width="wrap_content"
newt (away) 2015/02/19 21:48:02 width should be match_parent
melandory 2015/02/19 22:36:50 Done.
+ android:layout_height="wrap_content">
+ <ListView
newt (away) 2015/02/19 21:48:02 nit: fix indentation. It should be like the indent
melandory 2015/02/19 22:36:50 Done.
+ android:id="@+id/account_list"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:padding="8dp"/>
+</FrameLayout>

Powered by Google App Engine
This is Rietveld 408576698