chrome/android/java/res/layout/account_chooser_infobar_list.xml - Issue 861103002: Credentials chooser UI for Android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/account_chooser_infobar_list.xml

Issue 861103002: Credentials chooser UI for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Please review. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/account_chooser_infobar_item.xml ('K') | « chrome/android/java/res/layout/account_chooser_infobar_item.xml ('k') | chrome/android/java/res/menu/account_chooser_infobar_more_menu_popup.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5 <FrameLayout
	newt (away) 2015/02/19 21:49:27 It's OK to keep this FrameLayout. We could fix Inf It's OK to keep this FrameLayout. We could fix InfoBarLayout to respect the custom view's layout params, but for now, this is fine. melandory 2015/02/19 22:36:50 Acknowledged. Show quoted text On 2015/02/19 21:49:27, newt wrote: > It's OK to keep this FrameLayout. We could fix InfoBarLayout to respect the > custom view's layout params, but for now, this is fine. Acknowledged.
	6 xmlns:android="http://schemas.android.com/apk/res/android"

	7 android:layout_width="wrap_content"
	newt (away) 2015/02/19 21:48:02 width should be match_parent width should be match_parent melandory 2015/02/19 22:36:50 Done. Show quoted text On 2015/02/19 21:48:02, newt wrote: > width should be match_parent Done.
	8 android:layout_height="wrap_content">

	9 <ListView
	newt (away) 2015/02/19 21:48:02 nit: fix indentation. It should be like the indent nit: fix indentation. It should be like the indentation in account_chooser_infobar_item.xml melandory 2015/02/19 22:36:50 Done. Show quoted text On 2015/02/19 21:48:02, newt wrote: > nit: fix indentation. It should be like the indentation in > account_chooser_infobar_item.xml Done.
	10 android:id="@+id/account_list"

	11 android:layout_width="match_parent"

	12 android:layout_height="wrap_content"

	13 android:padding="8dp"/>

	14 </FrameLayout>

OLD	NEW