Credentials chooser UI for Android.

chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java

Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java
new file mode 100644
index 0000000000000000000000000000000000000000..912af2331a3cf37f2cf1bc0ff864096b1d4a6b88
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java
@@ -0,0 +1,187 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.infobar;
+
+import android.content.Context;
+import android.view.LayoutInflater;
+import android.view.MenuItem;
+import android.view.View;
+import android.view.View.OnClickListener;
+import android.view.ViewGroup;
+import android.widget.ArrayAdapter;
+import android.widget.Button;
+import android.widget.FrameLayout;
+import android.widget.ImageView;
+import android.widget.LinearLayout;
+import android.widget.ListView;
+import android.widget.PopupMenu;
+import android.widget.PopupMenu.OnMenuItemClickListener;
+import android.widget.TextView;
+
+import org.chromium.base.CalledByNative;
+import org.chromium.chrome.R;
+import org.chromium.chrome.browser.ResourceId;
+import org.chromium.chrome.browser.preferences.PreferencesLauncher;
+import org.chromium.chrome.browser.widget.ButtonCompat;
+
+/**
+ * An infobar which allows user to choose credentials.

[newt (away), 2015/02/19 21:48:02]

Can you improve this comment a bit. Which credentials? Why is the user choosing
them?

[melandory, 2015/02/19 22:36:50]

Done.

+ * Provides JNI methods for the infobar which allows user to choose account in
+ * Google Smart Lock.
+ */
+public class AccountChooserInfoBar extends InfoBar implements OnMenuItemClickListener {
+    private enum CredentialType {
+        EMPTY(0),
+        LOCAL(1),
+        FEDERATED(2);
+
+        private final int mType;
+        private CredentialType(int type) {
+            mType = type;
+        };
+
+        public int getValue() {
+            return mType;
+        }
+    }
+
+    private final String[] mUsernames;
+
+    /**
+     * Creates and shows the infobar wich allows user to choose credentials for login.
+     * @param nativeInfoBar Pointer to the native infobar.
+     * @param enumeratedIconId Enum ID corresponding to the icon that the infobar will show.
+     * @param usernames Usernames to display in the infobar.
+     */
+    @CalledByNative
+    private static InfoBar show(long nativeInfoBar, int enumeratedIconId, String[] usernames) {
+        return new AccountChooserInfoBar(
+                nativeInfoBar, ResourceId.mapToDrawableId(enumeratedIconId), usernames);
+    }
+
+    /**
+     * Creates and shows the infobar  which allows user to choose credentials.
+     * @param nativeInfoBar Pointer to the native infobar.
+     * @param iconDrawableId Drawable ID corresponding to the icon that the infobar will show.
+     * @param usernames list of usernames to display in infobar.
+     */
+    public AccountChooserInfoBar(long nativeInfoBar, int iconDrawableId, String[] usernames) {
+        super(null /* Infobar Listener */, iconDrawableId, null /* bitmap*/,
+                null /* message to show */);
+        setNativeInfoBar(nativeInfoBar);
+        mUsernames = usernames;
+    }
+
+    @Override
+    public boolean onMenuItemClick(MenuItem item) {
+        if (item.getItemId() == R.id.settings) {
+            PreferencesLauncher.launchSettingsPage(getContext(), null);
+            return true;
+        }
+        // TODO(melandory): Learn more should open link to help center
+        // article which is not ready yet.
+        return false;
+    }
+
+    @Override
+    public void onCloseButtonClicked() {
+        // Notifies the native infobar, which closes the infobar.
+        nativeOnCloseButtonClicked(mNativeInfoBarPtr);
+    }
+
+    @Override
+    public void onButtonClicked(boolean isPrimaryButton) {
+        onCloseButtonClicked();
+    }
+
+    @Override
+    public void createContent(InfoBarLayout layout) {
+        layout.setMessage(getContext().getString(R.string.account_chooser_infobar_title));
+        createAccountsView(layout);
+        createCustomButtonsView(layout);
+    }
+
+    private void createAccountsView(InfoBarLayout layout) {
+        ViewGroup accountsView =

[newt (away), 2015/02/19 21:48:02]

nit: fix indentation

[melandory, 2015/02/19 22:36:50]

what is issue with indentation? clang-format think it's fine.

+                (ViewGroup) LayoutInflater.from(getContext())
+                        .inflate(R.layout.account_chooser_infobar_list, null, false);
+        ArrayAdapter<String> adapter = generateAccountsArrayAdapter(getContext(), mUsernames);
+        ListView listView = (ListView) accountsView.findViewById(R.id.account_list);
+        listView.setAdapter(adapter);
+        float numVisibleItems = adapter.getCount() > 2 ? 2.5f : adapter.getCount();
+        int listViewHeight = (int) (numVisibleItems
+                * getContext().getResources().getDimension(
+                          R.dimen.account_chooser_infobar_item_height));
+        listView.setLayoutParams(new FrameLayout.LayoutParams(
+                FrameLayout.LayoutParams.MATCH_PARENT, listViewHeight));
+        layout.setCustomContent(accountsView);
+    }
+
+    private ArrayAdapter<String> generateAccountsArrayAdapter(Context context, String[] usernames) {
+        return new ArrayAdapter<String>(context, 0, usernames) {
+            @Override
+            public View getView(int position, View convertView, ViewGroup parent) {
+                LinearLayout row =

[newt (away), 2015/02/19 21:48:02]

You should still reuse convertView if it's non-null, like you were doing before:

    if (convertView == null) {
        convertView =
LayoutInflater.from(getContext()).inflate(R.layout.account_chooser_infobar_item,
parent, false);
    }

Also, be sure to pass parent instead of null to inflate(). That'll ensure the
layout is inflated with the correct type of LayoutParams.

[melandory, 2015/02/19 22:36:50]

Done.

+                        (LinearLayout) LayoutInflater.from(getContext())
+                                .inflate(R.layout.account_chooser_infobar_item, null, false);
+                ImageView avatarView = (ImageView) row.findViewById(R.id.profile_image);
+                TextView usernameView = (TextView) row.findViewById(R.id.username);
+                TextView displayNameView = (TextView) row.findViewById(R.id.display_name);
+                String username = getItem(position);
+                usernameView.setText(username);
+                // TODO(melandory): View should show the full name. Temporarily the view shows
+                // username.
+                displayNameView.setText(username);
+                // TODO(melandory): View should show proper avatar. Temporarily the view shows
+                // blue man icon.
+                avatarView.setImageResource(R.drawable.account_management_no_picture);
+                final int currentCredentialIndex = position;
+                row.setOnClickListener(new View.OnClickListener() {
+                    @Override
+                    public void onClick(View view) {
+                        passCredentialsToNative(currentCredentialIndex);
+                    }
+                });
+                return row;
+            }
+        };
+    }
+
+    /**
+     * For the Account Chooser infobar different, than InfobarLayout has, appearance of button

[newt (away), 2015/02/19 21:48:02]

Please clarify this comment. I'm really not sure what it's saying.

[melandory, 2015/02/19 22:36:50]

Yeah, comment is a bit outdated. But it remineds me: "No thanks" button is blue
now, but according to mocks it shouldn't be blue. Should I in future create a
custom button and add it in a same way as "More" button or at some point it will
be possible to control appearance of infobar buttons?

+     * is required.
+     */
+    private void createCustomButtonsView(InfoBarLayout layout) {
+        layout.setButtons(getContext().getString(R.string.no_thanks), null);
+        Button moreButton = ButtonCompat.createBorderlessButton(getContext());
+        moreButton.setText(getContext().getString(R.string.more));
+        // TODO(melandory): Looks like spinner in mocks.
+        moreButton.setOnClickListener(new OnClickListener() {
+            @Override
+            public void onClick(View view) {
+                showMorePopup(view);
+            }
+        });
+        layout.setCustomViewInButtonRow(moreButton);
+    }
+
+    private void passCredentialsToNative(int credentialIndex) {
+        // TODO(melandory): Adding federated login support should change this
+        // code.
+        nativeOnCredentialClicked(
+                mNativeInfoBarPtr, credentialIndex, CredentialType.LOCAL.getValue());
+    }
+
+    /** Pops up menu with two items: Setting and Learn More when user clicks more button*/
+    private void showMorePopup(View v) {
+        PopupMenu popup = new PopupMenu(getContext(), v);
+        popup.setOnMenuItemClickListener(this);
+        popup.inflate(R.menu.account_chooser_infobar_more_menu_popup);
+        popup.show();
+    }
+
+    private native void nativeOnCredentialClicked(
+            long nativeAccountChooserInfoBar, int credentialId, int credentialType);
+}