Set use_rndis_forwarder in platform backend.

Remove the android SetRndisForwarder() call from browser_backend and set it
directly in the platform_backend

When the needs_browser_restart_after_each_page flag is set to true in the page
test, we initialize the browser_backend twice and call SetRndisForwarder()
twice. Instead, we can make this call for the platform once.

Additionally, I added a simple unittest for the case when this flag is set.

BUG=450331
Committed: https://crrev.com/d26579b485b0cb323af99487c524ac8ff751e2ef
Cr-Commit-Position: refs/heads/master@{#312882}

[ariblue, 2015-01-20 22:18:02]

ariblue@google.com changed reviewers:
+ chrishenry@google.com, nednguyen@google.com

[nednguyen, 2015-01-20 23:16:29]

https://codereview.chromium.org/860913003/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
(right):

https://codereview.chromium.org/860913003/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py:82:
self._platform_backend.SetRndisForwarder(self._use_rndis_forwarder)
It seems to me that this should belong to either user_story_runner or
shared_page_state. The finder's job should be simply about finding the platform
& browser, rather than configuring them.

[chrishenry, 2015-01-21 01:35:49]

https://codereview.chromium.org/860913003/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
(right):

https://codereview.chromium.org/860913003/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py:82:
self._platform_backend.SetRndisForwarder(self._use_rndis_forwarder)
On 2015/01/20 23:16:29, nednguyen wrote:
> It seems to me that this should belong to either user_story_runner or
> shared_page_state. The finder's job should be simply about finding the
platform
> & browser, rather than configuring them.

+1 to not put this logic in browser finder. Should this be in platform directly?
This doesn't change from page to page right?

As mentioned in other thread, I'd love to see global forwarding logic be more
concentrated in platform and/or network_controller.

[ariblue, 2015-01-21 02:32:54]

https://codereview.chromium.org/860913003/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
(right):

https://codereview.chromium.org/860913003/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py:82:
self._platform_backend.SetRndisForwarder(self._use_rndis_forwarder)
On 2015/01/21 01:35:49, chrishenry wrote:
> On 2015/01/20 23:16:29, nednguyen wrote:
> > It seems to me that this should belong to either user_story_runner or
> > shared_page_state. The finder's job should be simply about finding the
> platform
> > & browser, rather than configuring them.
> 
> +1 to not put this logic in browser finder. Should this be in platform
directly?
> This doesn't change from page to page right?
> 
> As mentioned in other thread, I'd love to see global forwarding logic be more
> concentrated in platform and/or network_controller.

Done. However, it required passing finder_options around in several places. Look
reasonable?

[nednguyen, 2015-01-23 00:31:08]

nednguyen@google.com changed reviewers:
- chrishenry@google.com

[nednguyen, 2015-01-23 04:16:07]

lgtm with nits. Because cq cannot run unittest on android yet, please make sure
that the tests are passed on android.

https://codereview.chromium.org/860913003/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
(right):

https://codereview.chromium.org/860913003/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:68:
assert self.platform_backend.use_rndis_forwarder, (
I don't understand this.
if X or Y:
   assert Y

https://codereview.chromium.org/860913003/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py (right):

https://codereview.chromium.org/860913003/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py:143: def
testNeedsBrowserRestartAfterEachPage(self):
I don't think we need this test to catch the bug. The problem is CQ does not run
any unittests on Android at all. You could have catch it if

[nednguyen, 2015-01-23 17:15:53]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2015-01-23 17:16:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/860913003/20001

[commit-bot: I haz the power, 2015-01-23 18:42:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-23 18:43:26]

Patchset 2 (id:??) landed as
https://crrev.com/d26579b485b0cb323af99487c524ac8ff751e2ef
Cr-Commit-Position: refs/heads/master@{#312882}

[nednguyen, 2015-03-09 21:07:35]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/994583004/ by nednguyen@google.com.

The reason for reverting is: Speculative revert for
https://code.google.com/p/chromium/issues/detail?id=452080.