tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py - Issue 860913003: Set use_rndis_forwarder in platform backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py

Issue 860913003: Set use_rndis_forwarder in platform backend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move to platform. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py ('K') | « tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py ('k') | tools/telemetry/telemetry/core/platform/__init__.py » ('j') | tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py

index 7ea3deafe9bbc40d16e355978fb8b74479905e81..6c57c9751a897c58fbaf113bd490807d30dbf033 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py

@@ -106,7 +106,7 @@ def FindAllAvailableBrowsers(finder_options):

finder_options.cros_ssh_identity)

# Check ssh

try:

- platform = platform_module.GetPlatformForDevice(device)

+ platform = platform_module.GetPlatformForDevice(device, finder_options)

except cros_interface.LoginException, ex:

if isinstance(ex, cros_interface.KeylessLoginRequiredException):

logging.warn('Could not ssh into %s. Your device must be configured',