Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py

Issue 860913003: Set use_rndis_forwarder in platform backend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move to platform. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py
diff --git a/tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py b/tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py
index d9cfb48889dfef814ec68a7306c8ea2905e5667f..ce68d8bae8fe9d80109e1e6c294a698323dd737a 100644
--- a/tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py
+++ b/tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py
@@ -140,6 +140,37 @@ class PageRunEndToEndTests(unittest.TestCase):
self.assertEquals(1, len(GetSuccessfulPageRuns(results)))
self.assertEquals(1, len(results.failures))
+ def testNeedsBrowserRestartAfterEachPage(self):
nednguyen 2015/01/23 04:16:07 I don't think we need this test to catch the bug.
+ self.SuppressExceptionFormatting()
+ ps = page_set.PageSet()
+ expectations = test_expectations.TestExpectations()
+ ps.pages.append(page_module.Page(
+ 'file://blank.html', ps, base_dir=util.GetUnittestDataDir()))
+ ps.pages.append(page_module.Page(
+ 'file://blank.html', ps, base_dir=util.GetUnittestDataDir()))
+
+ class Test(page_test.PageTest):
+ def __init__(self, *args, **kwargs):
+ super(Test, self).__init__(*args, **kwargs)
+ self.browser_starts = 0
+
+ def DidStartBrowser(self, *args):
+ super(Test, self).DidStartBrowser(*args)
+ self.browser_starts += 1
+
+ def ValidateAndMeasurePage(self, page, tab, results):
+ pass
+
+ options = options_for_unittests.GetCopy()
+ options.output_formats = ['none']
+ options.suppress_gtest_report = True
+ test = Test(needs_browser_restart_after_each_page=True)
+ SetUpUserStoryRunnerArguments(options)
+ results = results_options.CreateResults(EmptyMetadataForTest(), options)
+ user_story_runner.Run(test, ps, expectations, options, results)
+ self.assertEquals(2, len(GetSuccessfulPageRuns(results)))
+ self.assertEquals(2, test.browser_starts)
+
def testHandlingOfCrashedTabWithExpectedFailure(self):
self.SuppressExceptionFormatting()
ps = page_set.PageSet()

Powered by Google App Engine
This is Rietveld 408576698