Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 860563003: Disable display item caching (Closed)

Created:
5 years, 11 months ago by Xianzhu
Modified:
5 years, 11 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, Rik, danakj, Dominik Röttsches, krit, f(malita), jbroman, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Disable display item caching Add RuntimeEnabledFeatures::slimmingPaintDisplayItemCacheEnabled flag which is false by default, disabling currently buggy display item caching. This requires that we always fully record for a layer (https://codereview.chromium.org/862773002/). Added DisplayItemList::beginNewPaints() and endNewPaints(). Without them we couldn't know if a new paint list is empty. After this CL, I'll work on fixing bugs of display item caching. As we paint the whole layer within the clip, the problems seem simpler than we expected. BUG=444163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188708

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Remove beginNewPaints and m_doingNewPaints #

Patch Set 4 : Remove beginNewPaints and m_doingNewPaints #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -9 lines) Patch
M Source/core/paint/DrawingRecorderTest.cpp View 1 2 4 chunks +4 lines, -0 lines 0 comments Download
M Source/core/paint/LayerClipRecorderTest.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/paint/ViewDisplayListTest.cpp View 1 2 24 chunks +40 lines, -5 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/ContentLayerDelegate.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/paint/DisplayItemList.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M Source/platform/graphics/paint/DisplayItemList.cpp View 1 2 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Xianzhu
5 years, 11 months ago (2015-01-20 22:46:41 UTC) #2
chrishtr
https://codereview.chromium.org/860563003/diff/20001/Source/platform/graphics/paint/DisplayItemList.cpp File Source/platform/graphics/paint/DisplayItemList.cpp (right): https://codereview.chromium.org/860563003/diff/20001/Source/platform/graphics/paint/DisplayItemList.cpp#newcode57 Source/platform/graphics/paint/DisplayItemList.cpp:57: ASSERT(!m_doingNewPaints && m_newPaints.isEmpty()); Looks like m_doingNewPaints is only used ...
5 years, 11 months ago (2015-01-20 23:18:53 UTC) #3
Xianzhu
https://codereview.chromium.org/860563003/diff/20001/Source/platform/graphics/paint/DisplayItemList.cpp File Source/platform/graphics/paint/DisplayItemList.cpp (right): https://codereview.chromium.org/860563003/diff/20001/Source/platform/graphics/paint/DisplayItemList.cpp#newcode57 Source/platform/graphics/paint/DisplayItemList.cpp:57: ASSERT(!m_doingNewPaints && m_newPaints.isEmpty()); On 2015/01/20 23:18:53, chrishtr wrote: > ...
5 years, 11 months ago (2015-01-20 23:48:11 UTC) #4
chrishtr
lgtm
5 years, 11 months ago (2015-01-20 23:53:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860563003/80001
5 years, 11 months ago (2015-01-20 23:53:58 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 03:40:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188708

Powered by Google App Engine
This is Rietveld 408576698