Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Unified Diff: Source/core/paint/DrawingRecorderTest.cpp

Issue 860563003: Disable display item caching (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove beginNewPaints and m_doingNewPaints Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/paint/LayerClipRecorderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/DrawingRecorderTest.cpp
diff --git a/Source/core/paint/DrawingRecorderTest.cpp b/Source/core/paint/DrawingRecorderTest.cpp
index ccb87dca70b3cd51780128ce26bb8869ebc0201c..c5990384a1d1741bf3ffc73615085a309f3bb90e 100644
--- a/Source/core/paint/DrawingRecorderTest.cpp
+++ b/Source/core/paint/DrawingRecorderTest.cpp
@@ -61,6 +61,7 @@ TEST_F(DrawingRecorderTest, DrawingRecorderTest_Nothing)
EXPECT_EQ((size_t)0, rootDisplayItemList().paintList().size());
drawNothing(&context, renderView(), PaintPhaseForeground, bound);
+ rootDisplayItemList().endNewPaints();
EXPECT_EQ((size_t)1, rootDisplayItemList().paintList().size());
#ifndef NDEBUG
EXPECT_STREQ("Dummy", rootDisplayItemList().paintList()[0]->name());
@@ -72,6 +73,7 @@ TEST_F(DrawingRecorderTest, DrawingRecorderTest_Rect)
GraphicsContext context(nullptr, &rootDisplayItemList());
FloatRect bound = renderView()->viewRect();
drawRect(&context, renderView(), PaintPhaseForeground, bound);
+ rootDisplayItemList().endNewPaints();
EXPECT_EQ((size_t)1, rootDisplayItemList().paintList().size());
#ifndef NDEBUG
EXPECT_STREQ("Drawing", rootDisplayItemList().paintList()[0]->name());
@@ -84,6 +86,7 @@ TEST_F(DrawingRecorderTest, DrawingRecorderTest_Cached)
FloatRect bound = renderView()->viewRect();
drawNothing(&context, renderView(), PaintPhaseBlockBackground, bound);
drawRect(&context, renderView(), PaintPhaseForeground, bound);
+ rootDisplayItemList().endNewPaints();
EXPECT_EQ((size_t)2, rootDisplayItemList().paintList().size());
#ifndef NDEBUG
EXPECT_STREQ("Dummy", rootDisplayItemList().paintList()[0]->name());
@@ -92,6 +95,7 @@ TEST_F(DrawingRecorderTest, DrawingRecorderTest_Cached)
drawNothing(&context, renderView(), PaintPhaseBlockBackground, bound);
drawRect(&context, renderView(), PaintPhaseForeground, bound);
+ rootDisplayItemList().endNewPaints();
EXPECT_EQ((size_t)2, rootDisplayItemList().paintList().size());
#ifndef NDEBUG
EXPECT_STREQ("Dummy", rootDisplayItemList().paintList()[0]->name());
« no previous file with comments | « no previous file | Source/core/paint/LayerClipRecorderTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698