Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 860423004: Remove css !important (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium, ojan
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove css !important Sky doesn't have important, it just orders properties in the same order as the rules you specified. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/98e91c1c069be7a7337c05778b3c17f99a130a6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -498 lines) Patch
M sky/engine/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/DeferredLegacyStyleInterpolationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/StringKeyframe.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/css/CSSAnimations.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.h View 3 chunks +1 line, -3 lines 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M sky/engine/core/css/CSSMatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/CSSProperty.h View 4 chunks +3 lines, -6 lines 0 comments Download
M sky/engine/core/css/CSSPropertySourceData.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/css/CSSPropertySourceData.cpp View 5 chunks +2 lines, -7 lines 0 comments Download
M sky/engine/core/css/CSSStyleDeclaration.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/css/CSSStyleDeclaration.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/DOMWindowCSS.cpp View 2 chunks +1 line, -19 lines 0 comments Download
M sky/engine/core/css/FontFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/FontFaceSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/PropertySetCSSStyleDeclaration.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/css/PropertySetCSSStyleDeclaration.cpp View 3 chunks +3 lines, -15 lines 0 comments Download
M sky/engine/core/css/StylePropertySerializer.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/StylePropertySerializer.cpp View 12 chunks +10 lines, -34 lines 0 comments Download
M sky/engine/core/css/StylePropertySet.h View 3 chunks +4 lines, -6 lines 0 comments Download
M sky/engine/core/css/StylePropertySet.cpp View 8 chunks +12 lines, -33 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser.h View 5 chunks +5 lines, -6 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 18 chunks +29 lines, -35 lines 0 comments Download
M sky/engine/core/css/parser/CSSGrammar.y View 7 chunks +12 lines, -21 lines 0 comments Download
M sky/engine/core/css/parser/CSSParserObserver.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.h View 8 chunks +32 lines, -32 lines 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 87 chunks +212 lines, -212 lines 0 comments Download
M sky/engine/core/css/parser/CSSTokenizer-in.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 7 chunks +7 lines, -21 lines 0 comments Download
M sky/engine/core/dom/Element.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/engine/core/editing/EditingStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/editing/EditingStyle.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
5 years, 11 months ago (2015-01-21 22:31:42 UTC) #2
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-21 22:32:41 UTC) #3
esprehn
5 years, 11 months ago (2015-01-21 22:34:07 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
98e91c1c069be7a7337c05778b3c17f99a130a6d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698