Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: sky/engine/core/css/parser/BisonCSSParser.h

Issue 860423004: Remove css !important (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/css/StylePropertySet.cpp ('k') | sky/engine/core/css/parser/BisonCSSParser-in.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/css/parser/BisonCSSParser.h
diff --git a/sky/engine/core/css/parser/BisonCSSParser.h b/sky/engine/core/css/parser/BisonCSSParser.h
index 68b66c4c9bf556e98ddfda47aee3dc005f7ef22c..1bd4a6dd46dd74267ceae8ed056ad78e17a6f68f 100644
--- a/sky/engine/core/css/parser/BisonCSSParser.h
+++ b/sky/engine/core/css/parser/BisonCSSParser.h
@@ -87,7 +87,7 @@ public:
PassRefPtr<StyleRuleBase> parseRule(StyleSheetContents*, const String&);
PassRefPtr<StyleKeyframe> parseKeyframeRule(StyleSheetContents*, const String&);
bool parseSupportsCondition(const String&);
- static bool parseValue(MutableStylePropertySet*, CSSPropertyID, const String&, bool important, CSSParserMode, StyleSheetContents*);
+ static bool parseValue(MutableStylePropertySet*, CSSPropertyID, const String&, CSSParserMode, StyleSheetContents*);
static bool parseColor(RGBA32& color, const String&, bool strict = false);
static StyleColor colorFromRGBColorString(const String&);
static bool parseSystemColor(RGBA32& color, const String&);
@@ -98,9 +98,9 @@ public:
PassOwnPtr<Vector<double> > parseKeyframeKeyList(const String&);
bool parseAttributeMatchType(CSSSelector::AttributeMatchType&, const String&);
- static bool parseValue(MutableStylePropertySet*, CSSPropertyID, const String&, bool important, const Document&);
+ static bool parseValue(MutableStylePropertySet*, CSSPropertyID, const String&, const Document&);
- bool parseValue(CSSPropertyID, bool important);
+ bool parseValue(CSSPropertyID);
void parseSelector(const String&, CSSSelectorList&);
CSSParserSelector* createFloatingSelector();
@@ -154,7 +154,6 @@ public:
CSSParserContext m_context;
- bool m_important;
CSSPropertyID m_id;
RawPtr<StyleSheetContents> m_styleSheet;
RefPtr<StyleRuleBase> m_rule;
@@ -184,7 +183,7 @@ public:
void endSelector();
void startRuleBody();
void startProperty();
- void endProperty(bool isImportantFound, bool isPropertyParsed, CSSParserError = NoCSSError);
+ void endProperty(bool isPropertyParsed, CSSParserError = NoCSSError);
void startEndUnknownRule();
void endInvalidRuleHeader();
@@ -212,7 +211,7 @@ private:
}
void setupParser(const char* prefix, unsigned prefixLength, const String&, const char* suffix, unsigned suffixLength);
- bool parseValue(MutableStylePropertySet*, CSSPropertyID, const String&, bool important, StyleSheetContents* contextStyleSheet);
+ bool parseValue(MutableStylePropertySet*, CSSPropertyID, const String&, StyleSheetContents* contextStyleSheet);
PassRefPtr<ImmutableStylePropertySet> parseDeclaration(const String&, StyleSheetContents* contextStyleSheet);
bool parseColor(const String&);
« no previous file with comments | « sky/engine/core/css/StylePropertySet.cpp ('k') | sky/engine/core/css/parser/BisonCSSParser-in.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698