Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: sky/engine/core/css/CSSComputedStyleDeclaration.cpp

Issue 860423004: Remove css !important (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/css/CSSComputedStyleDeclaration.h ('k') | sky/engine/core/css/CSSMatrix.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Zack Rusin <zack@kde.org> 2 * Copyright (C) 2004 Zack Rusin <zack@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2011 Sencha, Inc. All rights reserved. 6 * Copyright (C) 2011 Sencha, Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Lesser General Public 9 * modify it under the terms of the GNU Lesser General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 2327 matching lines...) Expand 10 before | Expand all | Expand 10 after
2338 2338
2339 String CSSComputedStyleDeclaration::getPropertyValue(const String& propertyName) 2339 String CSSComputedStyleDeclaration::getPropertyValue(const String& propertyName)
2340 { 2340 {
2341 CSSPropertyID propertyID = cssPropertyID(propertyName); 2341 CSSPropertyID propertyID = cssPropertyID(propertyName);
2342 if (!propertyID) 2342 if (!propertyID)
2343 return String(); 2343 return String();
2344 ASSERT(CSSPropertyMetadata::isEnabledProperty(propertyID)); 2344 ASSERT(CSSPropertyMetadata::isEnabledProperty(propertyID));
2345 return getPropertyValue(propertyID); 2345 return getPropertyValue(propertyID);
2346 } 2346 }
2347 2347
2348 String CSSComputedStyleDeclaration::getPropertyPriority(const String&)
2349 {
2350 // All computed styles have a priority of not "important".
2351 return "";
2352 }
2353
2354 String CSSComputedStyleDeclaration::getPropertyShorthand(const String&) 2348 String CSSComputedStyleDeclaration::getPropertyShorthand(const String&)
2355 { 2349 {
2356 return ""; 2350 return "";
2357 } 2351 }
2358 2352
2359 bool CSSComputedStyleDeclaration::isPropertyImplicit(const String&) 2353 bool CSSComputedStyleDeclaration::isPropertyImplicit(const String&)
2360 { 2354 {
2361 return false; 2355 return false;
2362 } 2356 }
2363 2357
(...skipping 11 matching lines...) Expand all
2375 PassRefPtr<CSSValue> CSSComputedStyleDeclaration::getPropertyCSSValueInternal(CS SPropertyID propertyID) 2369 PassRefPtr<CSSValue> CSSComputedStyleDeclaration::getPropertyCSSValueInternal(CS SPropertyID propertyID)
2376 { 2370 {
2377 return getPropertyCSSValue(propertyID); 2371 return getPropertyCSSValue(propertyID);
2378 } 2372 }
2379 2373
2380 String CSSComputedStyleDeclaration::getPropertyValueInternal(CSSPropertyID prope rtyID) 2374 String CSSComputedStyleDeclaration::getPropertyValueInternal(CSSPropertyID prope rtyID)
2381 { 2375 {
2382 return getPropertyValue(propertyID); 2376 return getPropertyValue(propertyID);
2383 } 2377 }
2384 2378
2385 void CSSComputedStyleDeclaration::setPropertyInternal(CSSPropertyID id, const St ring&, bool, ExceptionState& exceptionState) 2379 void CSSComputedStyleDeclaration::setPropertyInternal(CSSPropertyID id, const St ring&, ExceptionState& exceptionState)
2386 { 2380 {
2387 exceptionState.throwDOMException(NoModificationAllowedError, "These styles a re computed, and therefore the '" + getPropertyNameString(id) + "' property is r ead-only."); 2381 exceptionState.throwDOMException(NoModificationAllowedError, "These styles a re computed, and therefore the '" + getPropertyNameString(id) + "' property is r ead-only.");
2388 } 2382 }
2389 2383
2390 PassRefPtr<CSSValueList> CSSComputedStyleDeclaration::valuesForBackgroundShortha nd() const 2384 PassRefPtr<CSSValueList> CSSComputedStyleDeclaration::valuesForBackgroundShortha nd() const
2391 { 2385 {
2392 static const CSSPropertyID propertiesBeforeSlashSeperator[5] = { CSSProperty BackgroundColor, CSSPropertyBackgroundImage, 2386 static const CSSPropertyID propertiesBeforeSlashSeperator[5] = { CSSProperty BackgroundColor, CSSPropertyBackgroundImage,
2393 CSSProperty BackgroundRepeat, CSSPropertyBackgroundAttachment, 2387 CSSProperty BackgroundRepeat, CSSPropertyBackgroundAttachment,
2394 CSSProperty BackgroundPosition }; 2388 CSSProperty BackgroundPosition };
2395 static const CSSPropertyID propertiesAfterSlashSeperator[3] = { CSSPropertyB ackgroundSize, CSSPropertyBackgroundOrigin, 2389 static const CSSPropertyID propertiesAfterSlashSeperator[3] = { CSSPropertyB ackgroundSize, CSSPropertyBackgroundOrigin,
2396 CSSPropertyB ackgroundClip }; 2390 CSSPropertyB ackgroundClip };
2397 2391
2398 RefPtr<CSSValueList> list = CSSValueList::createSlashSeparated(); 2392 RefPtr<CSSValueList> list = CSSValueList::createSlashSeparated();
2399 list->append(valuesForShorthandProperty(StylePropertyShorthand(CSSPropertyBa ckground, propertiesBeforeSlashSeperator, WTF_ARRAY_LENGTH(propertiesBeforeSlash Seperator)))); 2393 list->append(valuesForShorthandProperty(StylePropertyShorthand(CSSPropertyBa ckground, propertiesBeforeSlashSeperator, WTF_ARRAY_LENGTH(propertiesBeforeSlash Seperator))));
2400 list->append(valuesForShorthandProperty(StylePropertyShorthand(CSSPropertyBa ckground, propertiesAfterSlashSeperator, WTF_ARRAY_LENGTH(propertiesAfterSlashSe perator)))); 2394 list->append(valuesForShorthandProperty(StylePropertyShorthand(CSSPropertyBa ckground, propertiesAfterSlashSeperator, WTF_ARRAY_LENGTH(propertiesAfterSlashSe perator))));
2401 return list.release(); 2395 return list.release();
2402 } 2396 }
2403 2397
2404 } // namespace blink 2398 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/core/css/CSSComputedStyleDeclaration.h ('k') | sky/engine/core/css/CSSMatrix.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698