Issue 85943003: Rename serial.[open,close] to [connect,disconnect]

Issue 85943003: Rename serial.[open,close] to [connect,disconnect] (Closed)

Created:
7 years ago by Ken Rockot(use gerrit already)

Modified:
7 years ago

Reviewers:
miket_OOO

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename serial.[open,close] to [connect,disconnect] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237156

Patch Set 2 : comments #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -86 lines)			Patch
M	chrome/browser/extensions/api/serial/serial_api.h	View		3 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/extensions/api/serial/serial_api.cc	View		6 chunks	+29 lines, -23 lines	0 comments	Download
M	chrome/browser/extensions/api/serial/serial_apitest.cc	View		5 chunks	+20 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/api/serial/serial_connection.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/serial/serial_event_dispatcher.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_function_histogram_value.h	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/api/serial.idl	View	1	7 chunks	+31 lines, -32 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/serial/api/background.js	View		4 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ken Rockot(use gerrit already)

One last potential change to API surface. Rationale: https://groups.google.com/a/chromium.org/forum/#!topic/apps-dev/VZF_JQmOqbA Largely superficial, except connect provides more ...

7 years ago (2013-11-25 17:33:28 UTC) #1

miket_OOO

lgtm https://codereview.chromium.org/85943003/diff/1/chrome/common/extensions/api/serial.idl File chrome/common/extensions/api/serial.idl (right): https://codereview.chromium.org/85943003/diff/1/chrome/common/extensions/api/serial.idl#newcode131 chrome/common/extensions/api/serial.idl:131: // Callack from the <code>getInfo</code> method. spelling https://codereview.chromium.org/85943003/diff/1/chrome/common/extensions/api/serial.idl#newcode208 ...

7 years ago (2013-11-25 17:56:23 UTC) #2

Ken Rockot(use gerrit already)

https://codereview.chromium.org/85943003/diff/1/chrome/common/extensions/api/serial.idl File chrome/common/extensions/api/serial.idl (right): https://codereview.chromium.org/85943003/diff/1/chrome/common/extensions/api/serial.idl#newcode131 chrome/common/extensions/api/serial.idl:131: // Callack from the <code>getInfo</code> method. On 2013/11/25 17:56:23, ...

7 years ago (2013-11-25 18:28:59 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/85943003/20001

7 years ago (2013-11-25 18:29:13 UTC) #4

Message was sent while issue was closed.

Change committed as 237156

Expand Messages | Collapse Messages