chrome/browser/extensions/api/serial/serial_connection.cc - Issue 85943003: Rename serial.[open,close] to [connect,disconnect]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/serial/serial_connection.cc

Issue 85943003: Rename serial.[open,close] to [connect,disconnect] (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/serial/serial_connection.cc

diff --git a/chrome/browser/extensions/api/serial/serial_connection.cc b/chrome/browser/extensions/api/serial/serial_connection.cc

index 66e19cfb5a9fed91f9eecd9434d770677510b037..155026eaefa5a6808b91b24fb222178c1fb216ee 100644

--- a/chrome/browser/extensions/api/serial/serial_connection.cc

+++ b/chrome/browser/extensions/api/serial/serial_connection.cc

@@ -49,8 +49,8 @@ SerialConnection::SerialConnection(const std::string& port,

SerialConnection::~SerialConnection() {

DCHECK(open_complete_.is_null());

- io_handler_->CancelRead(api::serial::RECEIVE_ERROR_CLOSED);

- io_handler_->CancelWrite(api::serial::SEND_ERROR_CLOSED);

+ io_handler_->CancelRead(api::serial::RECEIVE_ERROR_DISCONNECTED);

+ io_handler_->CancelWrite(api::serial::SEND_ERROR_DISCONNECTED);

Close();

}