Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9216)

Unified Diff: chrome/test/data/extensions/api_test/serial/api/background.js

Issue 85943003: Rename serial.[open,close] to [connect,disconnect] (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/serial.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/serial/api/background.js
diff --git a/chrome/test/data/extensions/api_test/serial/api/background.js b/chrome/test/data/extensions/api_test/serial/api/background.js
index bdc3df7da8233a8a5ce4da190edd78b091310bb1..ff7f76b4963708c5b816840b5ebb7f0d72e8461a 100644
--- a/chrome/test/data/extensions/api_test/serial/api/background.js
+++ b/chrome/test/data/extensions/api_test/serial/api/background.js
@@ -39,9 +39,9 @@ var testSerial = function() {
break;
case 1:
var bitrate = 57600;
- console.log('Opening serial device ' + serialPort + ' at ' +
+ console.log('Connecting to serial device ' + serialPort + ' at ' +
bitrate + ' bps.');
- serial.open(serialPort, {bitrate: bitrate}, onOpen);
+ serial.connect(serialPort, {bitrate: bitrate}, onConnect);
break;
case 2:
serial.setControlSignals(connectionId, {dtr: true}, onSetControlSignals);
@@ -55,7 +55,7 @@ var testSerial = function() {
serial.send(connectionId, sendBuffer, onSend);
break;
case 50: // GOTO 4 EVER
- serial.close(connectionId, onClose);
+ serial.disconnect(connectionId, onDisconnect);
break;
default:
// Beware! If you forget to assign a case for your next test, the whole
@@ -75,7 +75,7 @@ var testSerial = function() {
doNextOperation();
}
- var onClose = function(result) {
+ var onDisconnect = function(result) {
chrome.test.assertTrue(result);
doNextOperation();
};
@@ -117,9 +117,10 @@ var testSerial = function() {
doNextOperation();
};
- var onOpen = function(connectionInfo) {
+ var onConnect = function(connectionInfo) {
+ chrome.test.assertTrue(!!connectionInfo,
+ 'Failed to connect to serial port.');
connectionId = connectionInfo.connectionId;
- chrome.test.assertTrue(connectionId > 0, 'Failed to open serial port.');
doNextOperation();
};
« no previous file with comments | « chrome/common/extensions/api/serial.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698