Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 85863003: Change DetailOutputMap to FieldValueMap (Closed)

Created:
7 years ago by Dan Beam
Modified:
7 years ago
CC:
chromium-reviews, benquan, tfarina, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Change map types that use DetailInput* as keys (DetailOutputMap, TextfieldMap, ComboboxMap) to use ServerFieldType instead. This is because changing country will rebuild inputs and we don't want stale pointers around. BUG=317837 TEST=existing regression tests R=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237685

Patch Set 1 : . #

Total comments: 3

Patch Set 2 : merge #

Total comments: 2

Patch Set 3 : mac compile, nits #

Patch Set 4 : mac compile #

Patch Set 5 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -272 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc View 1 2 3 4 4 chunks +39 lines, -67 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 23 chunks +59 lines, -62 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 20 chunks +43 lines, -48 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_types.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_view_delegate.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper.cc View 1 chunk +6 lines, -10 lines 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper_unittest.cc View 1 2 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/autofill/mock_autofill_dialog_view_delegate.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_details_container_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_section_container.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_section_container.mm View 1 2 5 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 2 15 chunks +24 lines, -34 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Dan Beam
7 years ago (2013-11-26 01:59:53 UTC) #1
Evan Stade
https://codereview.chromium.org/85863003/diff/80001/chrome/browser/ui/views/autofill/autofill_dialog_views.h File chrome/browser/ui/views/autofill/autofill_dialog_views.h (right): https://codereview.chromium.org/85863003/diff/80001/chrome/browser/ui/views/autofill/autofill_dialog_views.h#newcode305 chrome/browser/ui/views/autofill/autofill_dialog_views.h:305: typedef std::map<const DetailInput*, DecoratedTextfield*> TextfieldMap; can this type also ...
7 years ago (2013-11-26 15:32:45 UTC) #2
Dan Beam
https://codereview.chromium.org/85863003/diff/80001/chrome/browser/ui/views/autofill/autofill_dialog_views.h File chrome/browser/ui/views/autofill/autofill_dialog_views.h (right): https://codereview.chromium.org/85863003/diff/80001/chrome/browser/ui/views/autofill/autofill_dialog_views.h#newcode305 chrome/browser/ui/views/autofill/autofill_dialog_views.h:305: typedef std::map<const DetailInput*, DecoratedTextfield*> TextfieldMap; On 2013/11/26 15:32:46, Evan ...
7 years ago (2013-11-27 01:00:41 UTC) #3
Dan Beam
https://codereview.chromium.org/85863003/diff/80001/chrome/browser/ui/views/autofill/autofill_dialog_views.h File chrome/browser/ui/views/autofill/autofill_dialog_views.h (right): https://codereview.chromium.org/85863003/diff/80001/chrome/browser/ui/views/autofill/autofill_dialog_views.h#newcode305 chrome/browser/ui/views/autofill/autofill_dialog_views.h:305: typedef std::map<const DetailInput*, DecoratedTextfield*> TextfieldMap; On 2013/11/27 01:00:42, Dan ...
7 years ago (2013-11-27 01:01:06 UTC) #4
Dan Beam
On 2013/11/27 01:01:06, Dan Beam wrote: > https://codereview.chromium.org/85863003/diff/80001/chrome/browser/ui/views/autofill/autofill_dialog_views.h > File chrome/browser/ui/views/autofill/autofill_dialog_views.h (right): > > https://codereview.chromium.org/85863003/diff/80001/chrome/browser/ui/views/autofill/autofill_dialog_views.h#newcode305 ...
7 years ago (2013-11-27 01:09:14 UTC) #5
Dan Beam
On 2013/11/27 01:01:06, Dan Beam wrote: > https://codereview.chromium.org/85863003/diff/80001/chrome/browser/ui/views/autofill/autofill_dialog_views.h > File chrome/browser/ui/views/autofill/autofill_dialog_views.h (right): > > https://codereview.chromium.org/85863003/diff/80001/chrome/browser/ui/views/autofill/autofill_dialog_views.h#newcode305 ...
7 years ago (2013-11-27 01:09:15 UTC) #6
Dan Beam
screw it, was too impatient to wait for your response. done.
7 years ago (2013-11-27 04:10:36 UTC) #7
Evan Stade
lgtm https://codereview.chromium.org/85863003/diff/120001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (right): https://codereview.chromium.org/85863003/diff/120001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc#newcode2207 chrome/browser/ui/views/autofill/autofill_dialog_views.cc:2207: scoped_ptr<DetailInput> cvc_input; this is no longer needed
7 years ago (2013-11-27 18:33:22 UTC) #8
Dan Beam
+isherman@ for chrome/browser/ui/cocoa https://codereview.chromium.org/85863003/diff/120001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (right): https://codereview.chromium.org/85863003/diff/120001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc#newcode2207 chrome/browser/ui/views/autofill/autofill_dialog_views.cc:2207: scoped_ptr<DetailInput> cvc_input; On 2013/11/27 18:33:23, Evan ...
7 years ago (2013-11-27 23:48:55 UTC) #9
Ilya Sherman
cocoa lgtm, thanks
7 years ago (2013-11-27 23:53:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/85863003/180001
7 years ago (2013-11-28 01:29:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/85863003/180001
7 years ago (2013-11-28 02:06:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/85863003/180001
7 years ago (2013-11-28 02:35:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/85863003/180001
7 years ago (2013-11-28 03:05:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/85863003/180001
7 years ago (2013-11-28 03:32:56 UTC) #15
commit-bot: I haz the power
7 years ago (2013-11-28 05:38:35 UTC) #16
Message was sent while issue was closed. 
Change committed as 237685

Powered by Google App Engine
This is Rietveld 408576698