Change DetailOutputMap to FieldValueMap

chrome/browser/ui/views/autofill/autofill_dialog_views.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_DIALOG_VIEWS_H_
 #define CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_DIALOG_VIEWS_H_
 
 #include <map>
 #include <set>
 
@@ skipping 71 matching lines @@
   virtual void UpdateButtonStrip() OVERRIDE;
   virtual void UpdateOverlay() OVERRIDE;
   virtual void UpdateDetailArea() OVERRIDE;
   virtual void UpdateForErrors() OVERRIDE;
   virtual void UpdateNotificationArea() OVERRIDE;
   virtual void UpdateSection(DialogSection section) OVERRIDE;
   virtual void UpdateErrorBubble() OVERRIDE;
   virtual void FillSection(DialogSection section,
                            const DetailInput& originating_input) OVERRIDE;
   virtual void GetUserInput(DialogSection section,
-                            DetailOutputMap* output) OVERRIDE;
+                            FieldValueMap* output) OVERRIDE;
   virtual base::string16 GetCvc() OVERRIDE;
   virtual bool HitTestInput(const DetailInput& input,
                             const gfx::Point& screen_point) OVERRIDE;
   virtual bool SaveDetailsLocally() OVERRIDE;
   virtual const content::NavigationController* ShowSignIn() OVERRIDE;
   virtual void HideSignIn() OVERRIDE;
   virtual void ModelChanged() OVERRIDE;
   virtual TestableAutofillDialogView* GetTestableView() OVERRIDE;
   virtual void OnSignInResize(const gfx::Size& pref_size) OVERRIDE;
 
@@ skipping 192 matching lines @@
     AutofillDialogViewDelegate* delegate_;  // weak
 
     // If HasArrow() is true, the arrow should point at this.
     base::WeakPtr<views::View> arrow_centering_anchor_;
 
     std::vector<DialogNotification> notifications_;
 
     DISALLOW_COPY_AND_ASSIGN(NotificationArea);
   };
 
   typedef std::map<const DetailInput*, DecoratedTextfield*> TextfieldMap;

[Evan Stade, 2013/11/26 15:32:46]

can this type also be changed? Seems dangerous to keep a potentially stale
pointer around.

[Dan Beam, 2013/11/27 01:00:42]

right now I clear group.textfields in UpdateSectionImpl() here [1].  is that
good enough?

[1]
https://chromiumcodereview.appspot.com/63053003/diff/700001/chrome/browser/ui...

[Dan Beam, 2013/11/27 01:01:07]

er, InitInputsView

   typedef std::map<const DetailInput*, views::Combobox*> ComboboxMap;
 
   // A view that packs a label on the left and some related controls
   // on the right.
   class SectionContainer : public views::View {
    public:
     SectionContainer(const base::string16& label,
                      views::View* controls,
                      views::Button* proxy_button);
     virtual ~SectionContainer();
@@ skipping 361 matching lines @@
 
   // Delegate for the sign-in dialog's webview.
   scoped_ptr<AutofillDialogSignInDelegate> sign_in_delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillDialogViews);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_DIALOG_VIEWS_H_