Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7522)

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm

Issue 85863003: Change DetailOutputMap to FieldValueMap (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix tests Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm
index d3640930ab9947ecb94f4e76ac84aaa5f9a83def..477a22ef2f1f5dd294165de20c71d9d2170f4360 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm
@@ -139,12 +139,12 @@ TEST_F(AutofillSectionContainerTest, OutputMatchesDefinition) {
[popup selectItemWithTitle:@"02"];
[[container_ getField:EMAIL_ADDRESS] setStringValue:@"magic@example.org"];
- autofill::DetailOutputMap output;
+ autofill::FieldValueMap output;
[container_ getInputs:&output];
ASSERT_EQ(inputs.size(), output.size());
- EXPECT_EQ(ASCIIToUTF16("magic@example.org"), output[&inputs[0]]);
- EXPECT_EQ(ASCIIToUTF16("02"), output[&inputs[1]]);
+ EXPECT_EQ(ASCIIToUTF16("magic@example.org"), output[inputs[0].type]);
+ EXPECT_EQ(ASCIIToUTF16("02"), output[inputs[1].type]);
}
TEST_F(AutofillSectionContainerTest, SuggestionsPopulatedByController) {
@@ -217,7 +217,6 @@ TEST_F(AutofillSectionContainerTest, ControllerInformsValidity) {
inputs.push_back(kTestInputs[0]);
inputs.push_back(kTestInputs[1]);
- DetailOutputMap output;
ValidityMessages validity, validity2;
validity.Set(EMAIL_ADDRESS,
@@ -232,6 +231,7 @@ TEST_F(AutofillSectionContainerTest, ControllerInformsValidity) {
.WillRepeatedly(Return(&comboModel));
ResetContainer();
+ autofill::FieldValueMap output;
[container_ getInputs:&output];
EXPECT_CALL(delegate_, InputsAreValid(section_, output))
.WillOnce(Return(validity))

Powered by Google App Engine
This is Rietveld 408576698