OOP PDF: Override printing for MimeHandlerViewContainers.

OOP PDF: Override printing for MimeHandlerViewContainers.

Previously, calling print() on the window object for a plugin document
resulted in printing a blank page. This adds an OverridePrint method to
PrintWebViewHelper::Delegate so MimeHandlerViewContainers can replace
the default print behavior with posting a print message to the mime
handler.

BUG=448720
Committed: https://crrev.com/da51fc6ff30169780c2e6b8076e12d8d7b398f5a
Cr-Commit-Position: refs/heads/master@{#313011}

[Sam McNally, 2015-01-21 23:35:32]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2015-01-21 23:35:39]

Patchset #1 (id:20001) has been deleted

[Sam McNally, 2015-01-21 23:36:24]

sammc@chromium.org changed reviewers:
+ raymes@chromium.org

[raymes, 2015-01-22 00:58:58]

https://codereview.chromium.org/858363002/diff/40001/chrome/renderer/printing...
File chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc (right):

https://codereview.chromium.org/858363002/diff/40001/chrome/renderer/printing...
chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc:67:
base::DictionaryValue message;
Please add a comment here with a link to the PDF code where this is handled and
make a note of what this does, that it is particularly for PDF integration.

https://codereview.chromium.org/858363002/diff/40001/extensions/renderer/gues...
File
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
(right):

https://codereview.chromium.org/858363002/diff/40001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:77:
base::LazyInstance<
Please add a comment about what this tracks

https://codereview.chromium.org/858363002/diff/40001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:230:
converter->ToV8Value(&message, frame->mainWorldScriptContext()));
nit: maybe make this a function (and reuse it in
OnMimeHandlerViewGuestOnLoadCompleted)

[Sam McNally, 2015-01-22 03:22:19]

Patchset #2 (id:60001) has been deleted

[Sam McNally, 2015-01-22 03:23:29]

https://codereview.chromium.org/858363002/diff/40001/chrome/renderer/printing...
File chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc (right):

https://codereview.chromium.org/858363002/diff/40001/chrome/renderer/printing...
chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc:67:
base::DictionaryValue message;
On 2015/01/22 00:58:57, raymes wrote:
> Please add a comment here with a link to the PDF code where this is handled
and
> make a note of what this does, that it is particularly for PDF integration.

Done.

https://codereview.chromium.org/858363002/diff/40001/extensions/renderer/gues...
File
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
(right):

https://codereview.chromium.org/858363002/diff/40001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:77:
base::LazyInstance<
On 2015/01/22 00:58:57, raymes wrote:
> Please add a comment about what this tracks

Done.

[raymes, 2015-01-22 22:44:02]

lgtm

https://codereview.chromium.org/858363002/diff/100001/chrome/renderer/printin...
File chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc (right):

https://codereview.chromium.org/858363002/diff/100001/chrome/renderer/printin...
chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc:68: //
instructs the PDF plugin to print.
Can we make a note that this is here specifically to make window.print() and put
a link to the bug?

[Sam McNally, 2015-01-23 02:17:19]

sammc@chromium.org changed reviewers:
+ vitalybuka@chromium.org

[Sam McNally, 2015-01-23 02:17:19]

+vitalybuka for chrome/renderer/printing and components/printing

https://codereview.chromium.org/858363002/diff/100001/chrome/renderer/printin...
File chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc (right):

https://codereview.chromium.org/858363002/diff/100001/chrome/renderer/printin...
chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc:68: //
instructs the PDF plugin to print.
On 2015/01/22 22:44:02, raymes wrote:
> Can we make a note that this is here specifically to make window.print() and
put
> a link to the bug?

Done.

[Vitaly Buka (NO REVIEWS), 2015-01-23 19:45:37]

lgtm

[Sam McNally, 2015-01-24 07:06:09]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2015-01-24 07:06:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/858363002/160001

[commit-bot: I haz the power, 2015-01-24 07:10:41]

Committed patchset #6 (id:160001)

[commit-bot: I haz the power, 2015-01-24 07:12:04]

Patchset 6 (id:??) landed as
https://crrev.com/da51fc6ff30169780c2e6b8076e12d8d7b398f5a
Cr-Commit-Position: refs/heads/master@{#313011}