extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h - Issue 858363002: OOP PDF: Override printing for MimeHandlerViewContainers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h

Issue 858363002: OOP PDF: Override printing for MimeHandlerViewContainers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mime-handler-api-simpler

Patch Set: fix android compile and remove the test as it hits a probably dodgy assert Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/printing/renderer/print_web_view_helper.cc ('k') | extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h

diff --git a/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h b/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h

index 105323d30d94dca0de1c6d29bad99c9113e271a3..86183f1fec70b034fe1ff2dcdbfd6f44a658800d 100644

--- a/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h

+++ b/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h

@@ -5,6 +5,9 @@

#ifndef EXTENSIONS_RENDERER_GUEST_VIEW_MIME_HANDLER_VIEW_MIME_HANDLER_VIEW_CONTAINER_H_

#define EXTENSIONS_RENDERER_GUEST_VIEW_MIME_HANDLER_VIEW_MIME_HANDLER_VIEW_CONTAINER_H_

+#include <string>

+#include <vector>

#include "base/memory/linked_ptr.h"

#include "base/memory/weak_ptr.h"

#include "extensions/renderer/guest_view/guest_view_container.h"

@@ -41,6 +44,9 @@ class MimeHandlerViewContainer : public GuestViewContainer,

const GURL& original_url);

~MimeHandlerViewContainer() override;

+ static std::vector<MimeHandlerViewContainer*> FromRenderFrame(

+ content::RenderFrame* render_frame);

// BrowserPluginDelegate implementation.

void Ready() override;

void DidFinishLoading() override;

@@ -63,6 +69,9 @@ class MimeHandlerViewContainer : public GuestViewContainer,

void PostMessage(v8::Isolate* isolate,

v8::Handle<v8::Value> message);

+ // Post |message| to the guest.

+ void PostMessageFromValue(const base::Value& message);

private:

// Message handlers.

void OnCreateMimeHandlerViewGuestACK(int element_instance_id);