components/printing/renderer/print_web_view_helper.cc - Issue 858363002: OOP PDF: Override printing for MimeHandlerViewContainers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/printing/renderer/print_web_view_helper.cc

Issue 858363002: OOP PDF: Override printing for MimeHandlerViewContainers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mime-handler-api-simpler

Patch Set: fix android compile and remove the test as it hits a probably dodgy assert Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/printing/renderer/print_web_view_helper.h ('k') | extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/printing/renderer/print_web_view_helper.cc

diff --git a/components/printing/renderer/print_web_view_helper.cc b/components/printing/renderer/print_web_view_helper.cc

index dcd4305f2a1ee4927ce8b8002edb1f838fd0978d..60923cdf0bef5229f53a63a0c2de92b7fc3f0b7a 100644

--- a/components/printing/renderer/print_web_view_helper.cc

+++ b/components/printing/renderer/print_web_view_helper.cc

@@ -829,6 +829,9 @@ void PrintWebViewHelper::PrintPage(blink::WebLocalFrame* frame,

if (!IsScriptInitiatedPrintAllowed(frame, user_initiated))

return;

+ if (delegate_->OverridePrint(frame))

+ return;

if (!g_is_preview_enabled_) {

Print(frame, blink::WebNode(), true);

} else {