Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 858173002: DevTools: rename AsyncCallChainMap to AsyncOperationMap (Closed)

Created:
5 years, 11 months ago by yurys
Modified:
5 years, 11 months ago
Reviewers:
aandrey
CC:
blink-reviews, caseq+blink_chromium.org, paulirish+reviews_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, arv+blink, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: rename AsyncCallChainMap to AsyncOperationMap Async operations are now tracked using unique ids assigned by InspectorDebuggerAgent. This change uifies naming across the inspector code. Removed v8::Isolate param from InspectorDebuggerAgent::traceAsyncCallbackStarting as the agent already knows the isolate. BUG=439376 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188737

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -175 lines) Patch
M Source/bindings/core/v8/ScriptDebugServer.h View 3 1 chunk +2 lines, -0 lines 0 comments Download
D Source/core/inspector/AsyncCallChainMap.h View 1 chunk +0 lines, -91 lines 0 comments Download
M Source/core/inspector/AsyncCallTracker.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/AsyncCallTracker.cpp View 1 15 chunks +39 lines, -34 lines 0 comments Download
A + Source/core/inspector/AsyncOperationMap.h View 4 chunks +14 lines, -15 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/inspector/V8AsyncCallTracker.h View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/inspector/V8AsyncCallTracker.cpp View 5 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yurys
5 years, 11 months ago (2015-01-21 08:31:59 UTC) #2
yurys
This change is based on https://codereview.chromium.org/855383002/
5 years, 11 months ago (2015-01-21 08:52:28 UTC) #3
aandrey
lgtm
5 years, 11 months ago (2015-01-21 09:15:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858173002/60001
5 years, 11 months ago (2015-01-21 11:55:19 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 13:13:15 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188737

Powered by Google App Engine
This is Rietveld 408576698