Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Unified Diff: Source/core/inspector/InspectorDebuggerAgent.cpp

Issue 858173002: DevTools: rename AsyncCallChainMap to AsyncOperationMap (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorDebuggerAgent.h ('k') | Source/core/inspector/V8AsyncCallTracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorDebuggerAgent.cpp
diff --git a/Source/core/inspector/InspectorDebuggerAgent.cpp b/Source/core/inspector/InspectorDebuggerAgent.cpp
index 4cc1ac691e3dd58c021d77e7fc169288886aab8d..5c127b63823b666559751ea85ec405ab60713b1d 100644
--- a/Source/core/inspector/InspectorDebuggerAgent.cpp
+++ b/Source/core/inspector/InspectorDebuggerAgent.cpp
@@ -1107,10 +1107,12 @@ void InspectorDebuggerAgent::traceAsyncCallbackCompleted()
}
}
-void InspectorDebuggerAgent::traceAsyncCallbackStarting(v8::Isolate* isolate, int operationId)
+void InspectorDebuggerAgent::traceAsyncCallbackStarting(int operationId)
{
ASSERT(operationId > 0 || operationId == unknownAsyncOperationId);
AsyncCallChain* chain = operationId > 0 ? m_asyncOperations.get(operationId) : nullptr;
+ // FIXME: extract recursion check into a delegate.
+ v8::Isolate* isolate = scriptDebugServer().isolate();
int recursionLevel = V8RecursionScope::recursionLevel(isolate);
if (chain && (!recursionLevel || (recursionLevel == 1 && Microtask::performingCheckpoint(isolate)))) {
// Current AsyncCallChain corresponds to the bottommost JS call frame.
@@ -1147,7 +1149,7 @@ void InspectorDebuggerAgent::resetAsyncCallTracker()
m_currentAsyncCallChain.clear();
m_nestedAsyncCallCount = 0;
for (auto& listener: m_asyncCallTrackingListeners)
- listener->resetAsyncCallChains();
+ listener->resetAsyncOperations();
m_asyncOperations.clear();
}
« no previous file with comments | « Source/core/inspector/InspectorDebuggerAgent.h ('k') | Source/core/inspector/V8AsyncCallTracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698