Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 857433002: Revert of Revert of Remove accelerated hardware decode blacklist entry for Mac OS X. (Closed)

Created:
5 years, 11 months ago by sandersd (OOO until July 31)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Remove accelerated hardware decode blacklist entry for Mac OS X. (patchset #1 id:1 of https://codereview.chromium.org/853563003/) Reason for revert: Test failure corrected by: https://crrev.com/81a119ffed1edbb462b51ed5b25a421bb9a03298 Cr-Commit-Position: refs/heads/master@{#311726} Original issue's description: > Revert of Remove accelerated hardware decode blacklist entry for Mac OS X. (patchset #2 id:20001 of https://codereview.chromium.org/849143002/) > > Reason for revert: > This seems related to the regression here: > https://build.chromium.org/p/chromium.gpu/builders/Mac%20Release%20%28Intel%29/builds/45738 > > Original issue's description: > > Remove accelerated hardware decode blacklist entry for Mac OS X. > > > > Now that VTVideoDecodeAccelerator exists, this entry is not necessary. > > > > BUG=133828 > > > > Committed: https://crrev.com/c0e69446b02848fce2e311662a43b8e782304ae3 > > Cr-Commit-Position: refs/heads/master@{#311622} > > TBR=scherkus@chromium.org,sievers@chromium.org,sandersd@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=133828 > > Committed: https://crrev.com/17202a5a52388cf6e0807a243364f6c995eb82a1 > Cr-Commit-Position: refs/heads/master@{#311659} TBR=scherkus@chromium.org,sievers@chromium.org,ricow@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=133828 Committed: https://crrev.com/f4e60796cf7b76ce3c313e3b507751fda3b340e3 Cr-Commit-Position: refs/heads/master@{#311727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -21 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/software_rendering_list_json.cc View 2 chunks +6 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sandersd (OOO until July 31)
Created Revert of Revert of Remove accelerated hardware decode blacklist entry for Mac OS X.
5 years, 11 months ago (2015-01-15 20:29:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857433002/1
5 years, 11 months ago (2015-01-15 20:30:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 20:31:20 UTC) #3
scherkus (not reviewing)
lgtm although my preference for re-landing CLs is to usually cherry-pick and re-upload with an ...
5 years, 11 months ago (2015-01-15 20:31:37 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 20:32:38 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4e60796cf7b76ce3c313e3b507751fda3b340e3
Cr-Commit-Position: refs/heads/master@{#311727}

Powered by Google App Engine
This is Rietveld 408576698