Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 849143002: Remove accelerated hardware decode blacklist entry for Mac OS X. (Closed)

Created:
5 years, 11 months ago by sandersd (OOO until July 31)
Modified:
5 years, 10 months ago
Reviewers:
acumoncxm, no sievers, scherkus (not reviewing)
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove accelerated hardware decode blacklist entry for Mac OS X. Now that VTVideoDecodeAccelerator exists, this entry is not necessary. BUG=133828 Committed: https://crrev.com/c0e69446b02848fce2e311662a43b8e782304ae3 Cr-Commit-Position: refs/heads/master@{#311622}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -21 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/software_rendering_list_json.cc View 1 2 chunks +6 lines, -20 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
sandersd (OOO until July 31)
5 years, 11 months ago (2015-01-14 23:14:04 UTC) #2
scherkus (not reviewing)
lgtm
5 years, 11 months ago (2015-01-14 23:18:06 UTC) #3
sandersd (OOO until July 31)
sievers@chromium.org: Please review changes in gpu/config.
5 years, 11 months ago (2015-01-14 23:22:06 UTC) #5
no sievers
https://codereview.chromium.org/849143002/diff/1/gpu/config/software_rendering_list_json.cc File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/849143002/diff/1/gpu/config/software_rendering_list_json.cc#newcode21 gpu/config/software_rendering_list_json.cc:21: "version": "9.15", bump this number https://codereview.chromium.org/849143002/diff/1/gpu/config/software_rendering_list_json.cc#newcode525 gpu/config/software_rendering_list_json.cc:525: "os": { ...
5 years, 11 months ago (2015-01-15 00:31:39 UTC) #6
sandersd (OOO until July 31)
https://codereview.chromium.org/849143002/diff/1/gpu/config/software_rendering_list_json.cc File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/849143002/diff/1/gpu/config/software_rendering_list_json.cc#newcode21 gpu/config/software_rendering_list_json.cc:21: "version": "9.15", On 2015/01/15 00:31:38, sievers wrote: > bump ...
5 years, 11 months ago (2015-01-15 00:47:51 UTC) #7
no sievers
lgtm
5 years, 11 months ago (2015-01-15 00:50:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849143002/20001
5 years, 11 months ago (2015-01-15 02:19:59 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-15 03:17:44 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c0e69446b02848fce2e311662a43b8e782304ae3 Cr-Commit-Position: refs/heads/master@{#311622}
5 years, 11 months ago (2015-01-15 03:18:36 UTC) #12
ricow1
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/853563003/ by ricow@google.com. ...
5 years, 11 months ago (2015-01-15 13:55:42 UTC) #13
acumoncxm_gmail.com
5 years, 10 months ago (2015-02-10 06:42:04 UTC) #14
Message was sent while issue was closed.
https://build.chromium.org/p/chromium.gpu/builders/Mac%20Release%20%28Intel%2....
 
this returns 404 Not found.

On Thursday, January 15, 2015 at 5:55:43 AM UTC-8, ri...@google.com wrote:
>
> A revert of this CL (patchset #2 id:20001) has been created in 
> https://codereview.chromium.org/853563003/ by ri...@google.com 
> <javascript:>. 
>
> The reason for reverting is: This seems related to the regression here: 
>
>
https://build.chromium.org/p/chromium.gpu/builders/Mac%20Release%20%28Intel%2....

>
>
> https://codereview.chromium.org/849143002/ 
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698