Replace incident type handlers with implementations of Incident.

Replace incident type handlers with implementations of Incident.

This is a refactor with no functional changes that paves the way for
planned work.

BUG=None

Committed: https://crrev.com/6aea7e7289a79728eb9d2d42e60421ae7dc21622
Cr-Commit-Position: refs/heads/master@{#311999}

[grt (UTC plus 2), 2015-01-15 21:44:13]

grt@chromium.org changed reviewers:
+ robertshield@chromium.org

[grt (UTC plus 2), 2015-01-15 21:44:24]

Please take a look when you have a chance. Thanks.

[robertshield, 2015-01-16 13:14:54]

lg, only minor thoughts on comment structure after yesterday's discussion

https://codereview.chromium.org/856543004/diff/1/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident.h
(right):

https://codereview.chromium.org/856543004/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident.h:23:
// Incident:
nit: maybe "Incident overrides:" to make it slightly more unambiguous? If the
"// BaseClass:" style comment is conventional, please ignore me.

https://codereview.chromium.org/856543004/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident.h:25:
// Returns IncidentType::BINARY_INTEGRITY.
moar nit: are these methods used by anyone other than the incident reporting
service? or are they effectively part of the contract between FooIncident and
the incident reporting service?
I ask, only because I wonder whether these comments should live in the header or
in the .cc file (since I believe there is also a mild convention to not add
comments to overrides).

https://codereview.chromium.org/856543004/diff/1/chrome/browser/safe_browsing...
File
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
(right):

https://codereview.chromium.org/856543004/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc:93:
static_cast<int32_t>(incident.GetType()));
nice :)

[grt (UTC plus 2), 2015-01-17 00:22:29]

Thanks for the review. Please take another look, and help yourself to the CQ box
if you like it as-is.

https://codereview.chromium.org/856543004/diff/1/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident.h
(right):

https://codereview.chromium.org/856543004/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident.h:23:
// Incident:
On 2015/01/16 13:14:54, robertshield wrote:
> nit: maybe "Incident overrides:" to make it slightly more unambiguous? If the
> "// BaseClass:" style comment is conventional, please ignore me. 

Someone (I don't remember who) asked me to do it the way it is in a different
CL. I've switched back to my preferred style, which is "// Foo methods:"

https://codereview.chromium.org/856543004/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident.h:25:
// Returns IncidentType::BINARY_INTEGRITY.
On 2015/01/16 13:14:54, robertshield wrote:
> moar nit: are these methods used by anyone other than the incident reporting
> service? or are they effectively part of the contract between FooIncident and
> the incident reporting service?
> I ask, only because I wonder whether these comments should live in the header
or
> in the .cc file (since I believe there is also a mild convention to not add
> comments to overrides).

Indeed these are documenting the implementation. Moved into .cc.

[robertshield, 2015-01-17 00:24:51]

The CQ bit was checked by robertshield@chromium.org

[robertshield, 2015-01-17 00:24:51]

lgtm

[commit-bot: I haz the power, 2015-01-17 00:25:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/856543004/40001

[commit-bot: I haz the power, 2015-01-17 01:10:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-17 01:12:31]

Patchset 3 (id:??) landed as
https://crrev.com/6aea7e7289a79728eb9d2d42e60421ae7dc21622
Cr-Commit-Position: refs/heads/master@{#311999}