chrome/browser/safe_browsing/incident_reporting/omnibox_incident_handlers.cc - Issue 856543004: Replace incident type handlers with implementations of Incident.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/safe_browsing/incident_reporting/omnibox_incident_handlers.cc

Issue 856543004: Replace incident type handlers with implementations of Incident. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: robertshield comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/omnibox_incident_handlers.h ('k') | chrome/browser/safe_browsing/incident_reporting/omnibox_interaction_incident.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.

4

5 #include "chrome/browser/safe_browsing/incident_reporting/omnibox_incident_handl ers.h"

6

7 #include "base/logging.h"

8 #include "chrome/common/safe_browsing/csd.pb.h"

9

10 namespace safe_browsing {

11

12 std::string GetOmniboxIncidentKey(

13 const ClientIncidentReport_IncidentData& incident_data) {

14 DCHECK(incident_data.has_omnibox_interaction());

15 // Return a constant, as only one kind of suspicious interaction is detected.

16 return std::string("1");

17 }

18

19 uint32_t GetOmniboxIncidentDigest(

20 const ClientIncidentReport_IncidentData& incident_data) {

21 DCHECK(incident_data.has_omnibox_interaction());

22 // Return a constant (independent of the incident's payload) so that only the

23 // first suspicious interaction is reported.

24 return 1u;

25 }

26

27 } // namespace safe_browsing

OLD	NEW