Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3322)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident_unittest.cc

Issue 856543004: Replace incident type handlers with implementations of Incident. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: robertshield comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident_unittest.cc
diff --git a/chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ce54404eee68b98dea49e9ba975cf79019ec4f65
--- /dev/null
+++ b/chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident_unittest.cc
@@ -0,0 +1,51 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident.h"
+
+#include "base/memory/scoped_ptr.h"
+#include "chrome/common/safe_browsing/csd.pb.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace safe_browsing {
+
+namespace {
+
+scoped_ptr<Incident> MakeIncident(bool changed) {
+ scoped_ptr<ClientIncidentReport_IncidentData_TrackedPreferenceIncident>
+ incident(new ClientIncidentReport_IncidentData_TrackedPreferenceIncident);
+
+ incident->set_path("foo");
+ incident->set_atomic_value("bar");
+ incident->set_value_state(
+ changed
+ ? ClientIncidentReport_IncidentData_TrackedPreferenceIncident_ValueState_CHANGED
+ : ClientIncidentReport_IncidentData_TrackedPreferenceIncident_ValueState_CLEARED);
+ return make_scoped_ptr(new TrackedPreferenceIncident(incident.Pass()));
+}
+
+} // namespace
+
+TEST(TrackedPreferenceIncident, GetType) {
+ ASSERT_EQ(IncidentType::TRACKED_PREFERENCE, MakeIncident(false)->GetType());
+}
+
+// Tests that GetKey returns the preference path.
+TEST(TrackedPreferenceIncident, KeyIsPath) {
+ ASSERT_EQ(std::string("foo"), MakeIncident(false)->GetKey());
+}
+
+// Tests that GetDigest returns the same value for the same incident.
+TEST(TrackedPreferenceIncident, SameIncidentSameDigest) {
+ ASSERT_EQ(MakeIncident(false)->ComputeDigest(),
+ MakeIncident(false)->ComputeDigest());
+}
+
+// Tests that GetDigest returns a different value for different incidents.
+TEST(TrackedPreferenceIncident, DifferentIncidentDifferentDigest) {
+ ASSERT_NE(MakeIncident(false)->ComputeDigest(),
+ MakeIncident(true)->ComputeDigest());
+}
+
+} // namespace safe_browsing

Powered by Google App Engine
This is Rietveld 408576698