Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 856493004: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/login. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
piman
CC:
chromium-reviews, davemoore+watch_chromium.org, dzhioev+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/login. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=piman@chromium.org Committed: https://crrev.com/ce340ea798bfd1b19700df5b82b56b1e96144369 Cr-Commit-Position: refs/heads/master@{#311790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -453 lines) Patch
M chrome/browser/chromeos/login/app_launch_controller.h View 2 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_controller.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_signin_screen.h View 2 chunks +29 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/login/auth/auth_prewarmer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/auth/chrome_login_performer.h View 1 chunk +17 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/auth/online_attempt_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/crash_restore_browsertest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/demo_mode/demo_app_launcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_reauth.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_user_login_flow.h View 1 chunk +10 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/short_lived_user_context.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.h View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen.h View 2 chunks +20 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/mock_auto_enrollment_check_screen.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/enrollment/mock_enrollment_screen.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/error_screens_histogram_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 3 chunks +30 lines, -32 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_auto_login_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 8 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/fake_login_utils.h View 1 chunk +8 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 13 chunks +23 lines, -27 lines 0 comments Download
M chrome/browser/chromeos/login/login_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/login_manager_test.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/login_screen_policy_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +9 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/mixin_based_browser_test.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/oobe_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/oobe_localization_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/profile_auth_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/reset_browsertest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_offline_signin_limiter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_offline_signin_limiter_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_offline_signin_limiter_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screenshot_testing/screenshot_testing_mixin.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/session/chrome_session_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/session/kiosk_auto_launcher_session_manager_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/session/login_oobe_session_manager_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/session/restore_after_crash_session_manager_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/session/stub_login_session_manager_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.h View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/session_login_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/signin/auth_sync_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/signin/auth_sync_observer_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/signin/merge_session_load_page.h View 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/signin/merge_session_load_page_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/signin/merge_session_throttle.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/signin/merge_session_xhr_request_waiter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_browsertest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_login_manager_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/signin_screen_controller.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/test/app_window_waiter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/test/https_forwarder.h View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/test/oobe_base_test.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/test/oobe_screen_waiter.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/test/wizard_in_process_browser_test.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/user_flow.h View 1 chunk +17 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/login/version_info_updater.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 3 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 13 chunks +23 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
5 years, 11 months ago (2015-01-15 21:08:19 UTC) #1
piman
lgtm
5 years, 11 months ago (2015-01-15 22:14:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856493004/1
5 years, 11 months ago (2015-01-15 22:54:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 00:47:19 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 00:48:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce340ea798bfd1b19700df5b82b56b1e96144369
Cr-Commit-Position: refs/heads/master@{#311790}

Powered by Google App Engine
This is Rietveld 408576698