Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: chrome/browser/chromeos/login/oobe_localization_browsertest.cc

Issue 856493004: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/login. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/message_loop/message_loop.h" 5 #include "base/message_loop/message_loop.h"
6 #include "base/prefs/pref_service.h" 6 #include "base/prefs/pref_service.h"
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "base/task_runner.h" 8 #include "base/task_runner.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/chrome_notification_types.h" 10 #include "chrome/browser/chrome_notification_types.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 class LanguageListWaiter : public NetworkScreen::Observer { 45 class LanguageListWaiter : public NetworkScreen::Observer {
46 public: 46 public:
47 explicit LanguageListWaiter(base::RunLoop& loop) 47 explicit LanguageListWaiter(base::RunLoop& loop)
48 : network_screen_( 48 : network_screen_(
49 NetworkScreen::Get(WizardController::default_controller())), 49 NetworkScreen::Get(WizardController::default_controller())),
50 loop_(loop) { 50 loop_(loop) {
51 network_screen_->AddObserver(this); 51 network_screen_->AddObserver(this);
52 CheckLanguageList(); 52 CheckLanguageList();
53 } 53 }
54 54
55 virtual ~LanguageListWaiter() { network_screen_->RemoveObserver(this); } 55 ~LanguageListWaiter() override { network_screen_->RemoveObserver(this); }
56 56
57 // NetworkScreen::Observer implementation: 57 // NetworkScreen::Observer implementation:
58 virtual void OnLanguageListReloaded() override { CheckLanguageList(); } 58 void OnLanguageListReloaded() override { CheckLanguageList(); }
59 59
60 private: 60 private:
61 void CheckLanguageList() { 61 void CheckLanguageList() {
62 if (network_screen_->GetLanguageList()) 62 if (network_screen_->GetLanguageList())
63 loop_.Quit(); 63 loop_.Quit();
64 } 64 }
65 65
66 NetworkScreen* network_screen_; 66 NetworkScreen* network_screen_;
67 base::RunLoop& loop_; 67 base::RunLoop& loop_;
68 }; 68 };
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
382 RunLocalizationTest(); 382 RunLocalizationTest();
383 } 383 }
384 384
385 INSTANTIATE_TEST_CASE_P( 385 INSTANTIATE_TEST_CASE_P(
386 StructSequence, 386 StructSequence,
387 OobeLocalizationTest, 387 OobeLocalizationTest,
388 testing::Range(&oobe_localization_test_parameters[0], 388 testing::Range(&oobe_localization_test_parameters[0],
389 &oobe_localization_test_parameters[arraysize( 389 &oobe_localization_test_parameters[arraysize(
390 oobe_localization_test_parameters)])); 390 oobe_localization_test_parameters)]));
391 } // namespace chromeos 391 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/login/oobe_browsertest.cc ('k') | chrome/browser/chromeos/login/profile_auth_data_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698