chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc - Issue 856493004: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/login.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc

Issue 856493004: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/login. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/demo_mode/demo_app_launcher.h ('k') | chrome/browser/chromeos/login/easy_unlock/easy_unlock_reauth.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc

diff --git a/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc b/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc

index d56a80b1d525923c73ea688b5a500c80294a2048..b5b5486ef80eab04154d1ff79a91432f20d982f6 100644

--- a/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc

+++ b/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc

@@ -64,9 +64,9 @@ class DemoAppLauncherTest : public ExtensionBrowserTest {

set_exit_when_last_browser_closes(false);

}

- virtual ~DemoAppLauncherTest() {}

+ ~DemoAppLauncherTest() override {}

- virtual void SetUpCommandLine(base::CommandLine* command_line) override {

+ void SetUpCommandLine(base::CommandLine* command_line) override {

command_line->AppendSwitch(switches::kLoginManager);

command_line->AppendSwitch(switches::kForceLoginManagerInTests);

command_line->AppendSwitchASCII(switches::kLoginProfile, "user");

@@ -76,7 +76,7 @@ class DemoAppLauncherTest : public ExtensionBrowserTest {

command_line->AppendSwitchASCII(switches::kDerelictDetectionTimeout, "0");

}

- virtual void SetUp() override {

+ void SetUp() override {

chromeos::DemoAppLauncher::SetDemoAppPathForTesting(GetTestDemoAppPath());

ExtensionBrowserTest::SetUp();

}