Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 854593002: Temporary make the call stack trace around PasswordStore::WrapModificationTask more useful. (Closed)

Created:
5 years, 11 months ago by vasilii
Modified:
5 years, 11 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporary make the call stack trace around PasswordStore::WrapModificationTask more useful. The patch is to be reverted a few days later when we have a crash report with the new stack trace. BUG=396900 Committed: https://crrev.com/6aabbbf1afea5df0fab267302c7a1e19c30b649b Cr-Commit-Position: refs/heads/master@{#311482}

Patch Set 1 #

Patch Set 2 : revert test files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -20 lines) Patch
M components/password_manager/core/browser/password_store.h View 1 chunk +9 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store.cc View 2 chunks +36 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vasilii
Hi Vaclav, please review the CL.
5 years, 11 months ago (2015-01-14 14:30:11 UTC) #2
vabr (Chromium)
This LGTM. After a conversation with Vasilii, I understand that the change in the non-test ...
5 years, 11 months ago (2015-01-14 14:48:39 UTC) #3
vasilii
I reverted the changes to test_password_store.*.
5 years, 11 months ago (2015-01-14 14:50:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854593002/20001
5 years, 11 months ago (2015-01-14 14:50:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 15:51:04 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 15:52:00 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6aabbbf1afea5df0fab267302c7a1e19c30b649b
Cr-Commit-Position: refs/heads/master@{#311482}

Powered by Google App Engine
This is Rietveld 408576698