Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: components/password_manager/core/browser/password_store.cc

Issue 854593002: Temporary make the call stack trace around PasswordStore::WrapModificationTask more useful. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert test files Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_store.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_store.cc
diff --git a/components/password_manager/core/browser/password_store.cc b/components/password_manager/core/browser/password_store.cc
index c83887fd7c31ad3ff16ef127a09a35ae6663bc49..f832a885d1c03699b8385457c95fbc79f1cbea49 100644
--- a/components/password_manager/core/browser/password_store.cc
+++ b/components/password_manager/core/browser/password_store.cc
@@ -96,41 +96,28 @@ bool PasswordStore::Init(const syncer::SyncableService::StartSyncFlare& flare) {
void PasswordStore::AddLogin(const PasswordForm& form) {
CheckForEmptyUsernameAndPassword(form);
- ScheduleTask(
- base::Bind(&PasswordStore::WrapModificationTask, this,
- base::Bind(&PasswordStore::AddLoginImpl, this, form)));
+ ScheduleTask(base::Bind(&PasswordStore::AddLoginInternal, this, form));
}
void PasswordStore::UpdateLogin(const PasswordForm& form) {
CheckForEmptyUsernameAndPassword(form);
- ScheduleTask(
- base::Bind(&PasswordStore::WrapModificationTask, this,
- base::Bind(&PasswordStore::UpdateLoginImpl, this, form)));
+ ScheduleTask(base::Bind(&PasswordStore::UpdateLoginInternal, this, form));
}
void PasswordStore::RemoveLogin(const PasswordForm& form) {
- ScheduleTask(
- base::Bind(&PasswordStore::WrapModificationTask, this,
- base::Bind(&PasswordStore::RemoveLoginImpl, this, form)));
+ ScheduleTask(base::Bind(&PasswordStore::RemoveLoginInternal, this, form));
}
void PasswordStore::RemoveLoginsCreatedBetween(base::Time delete_begin,
base::Time delete_end) {
- ScheduleTask(
- base::Bind(&PasswordStore::WrapModificationTask, this,
- base::Bind(&PasswordStore::RemoveLoginsCreatedBetweenImpl,
- this, delete_begin, delete_end)));
+ ScheduleTask(base::Bind(&PasswordStore::RemoveLoginsCreatedBetweenInternal,
+ this, delete_begin, delete_end));
}
void PasswordStore::RemoveLoginsSyncedBetween(base::Time delete_begin,
base::Time delete_end) {
- ScheduleTask(
- base::Bind(&PasswordStore::WrapModificationTask,
- this,
- base::Bind(&PasswordStore::RemoveLoginsSyncedBetweenImpl,
- this,
- delete_begin,
- delete_end)));
+ ScheduleTask(base::Bind(&PasswordStore::RemoveLoginsSyncedBetweenInternal,
+ this, delete_begin, delete_end));
}
void PasswordStore::GetLogins(
@@ -271,6 +258,35 @@ void PasswordStore::WrapModificationTask(ModificationTask task) {
NotifyLoginsChanged(changes);
}
+void PasswordStore::AddLoginInternal(const PasswordForm& form) {
+ PasswordStoreChangeList changes = AddLoginImpl(form);
+ NotifyLoginsChanged(changes);
+}
+
+void PasswordStore::UpdateLoginInternal(const PasswordForm& form) {
+ PasswordStoreChangeList changes = UpdateLoginImpl(form);
+ NotifyLoginsChanged(changes);
+}
+
+void PasswordStore::RemoveLoginInternal(const PasswordForm& form) {
+ PasswordStoreChangeList changes = RemoveLoginImpl(form);
+ NotifyLoginsChanged(changes);
+}
+
+void PasswordStore::RemoveLoginsCreatedBetweenInternal(base::Time delete_begin,
+ base::Time delete_end) {
+ PasswordStoreChangeList changes =
+ RemoveLoginsCreatedBetweenImpl(delete_begin, delete_end);
+ NotifyLoginsChanged(changes);
+}
+
+void PasswordStore::RemoveLoginsSyncedBetweenInternal(base::Time delete_begin,
+ base::Time delete_end) {
+ PasswordStoreChangeList changes =
+ RemoveLoginsSyncedBetweenImpl(delete_begin, delete_end);
+ NotifyLoginsChanged(changes);
+}
+
#if defined(PASSWORD_MANAGER_ENABLE_SYNC)
void PasswordStore::InitSyncableService(
const syncer::SyncableService::StartSyncFlare& flare) {
« no previous file with comments | « components/password_manager/core/browser/password_store.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698