Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: components/password_manager/core/browser/password_store.h

Issue 854593002: Temporary make the call stack trace around PasswordStore::WrapModificationTask more useful. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert test files Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_store.h
diff --git a/components/password_manager/core/browser/password_store.h b/components/password_manager/core/browser/password_store.h
index b678368cbaa3b742ae3af142ca3a8bdb859b4872..63d6d1e38edb5d7500d9927ad2917079c6c8e3d1 100644
--- a/components/password_manager/core/browser/password_store.h
+++ b/components/password_manager/core/browser/password_store.h
@@ -277,6 +277,15 @@ class PasswordStore : protected PasswordStoreSync,
// method will actually modify the password store data.
virtual void WrapModificationTask(ModificationTask task);
+ // Temporary specializations of WrapModificationTask for a better stack trace.
+ void AddLoginInternal(const autofill::PasswordForm& form);
+ void UpdateLoginInternal(const autofill::PasswordForm& form);
+ void RemoveLoginInternal(const autofill::PasswordForm& form);
+ void RemoveLoginsCreatedBetweenInternal(base::Time delete_begin,
+ base::Time delete_end);
+ void RemoveLoginsSyncedBetweenInternal(base::Time delete_begin,
+ base::Time delete_end);
+
// Copies |matched_forms| into the request's result vector, then calls
// |ForwardLoginsResult|. Temporarily used as an adapter between the API of
// |GetLoginsImpl| and |PasswordStoreConsumer|.
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698