Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 853983002: Fix js checker script (Closed)

Created:
5 years, 11 months ago by garykac
Modified:
5 years, 11 months ago
CC:
chromium-reviews, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, Ben Kwa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix js checker script The previous script update broke the closure compilation for some apps (like files.app). This fixes the problem by correcting the values passed into run_js_check. The problems can be repro'ed by running: GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/file_manager/*/js/compiled_resources.gyp && ninja -C out/Default; After this cl, the above command returns only a single (valid!) error. BUG= Committed: https://crrev.com/0b3e2467eabb57cb9630587f4e6ebb139f1224a6 Cr-Commit-Position: refs/heads/master@{#311743}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/closure_compiler/checker.py View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (2 generated)
garykac
5 years, 11 months ago (2015-01-15 18:53:28 UTC) #2
Tyler Breisacher (Chromium)
lgtm https://codereview.chromium.org/853983002/diff/1/third_party/closure_compiler/checker.py File third_party/closure_compiler/checker.py (right): https://codereview.chromium.org/853983002/diff/1/third_party/closure_compiler/checker.py#newcode243 third_party/closure_compiler/checker.py:243: errors, stderr = self.run_js_check([self._expanded_file], externs) run_js_check's first argument ...
5 years, 11 months ago (2015-01-15 20:43:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853983002/1
5 years, 11 months ago (2015-01-15 21:38:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 21:45:49 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 21:46:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b3e2467eabb57cb9630587f4e6ebb139f1224a6
Cr-Commit-Position: refs/heads/master@{#311743}

Powered by Google App Engine
This is Rietveld 408576698