third_party/closure_compiler/checker.py - Issue 853983002: Fix js checker script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/checker.py

Issue 853983002: Fix js checker script (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/closure_compiler/checker.py

diff --git a/third_party/closure_compiler/checker.py b/third_party/closure_compiler/checker.py

index 7d4620a80d4f9e24a85d67fb272094ec6439ae6c..2eb9e68a21f606fc41e3e6ba4859649483138d13 100755

--- a/third_party/closure_compiler/checker.py

+++ b/third_party/closure_compiler/checker.py

@@ -240,7 +240,7 @@ class Checker(object):

self._expanded_file = self._create_temp_file(self._processor.contents)

self._debug("Expanded file: %s" % self._expanded_file)

- errors, stderr = self.run_js_check(self._expanded_file, depends)

+ errors, stderr = self.run_js_check([self._expanded_file], externs)

Tyler Breisacher (Chromium) 2015/01/15 20:43:09 run_js_check's first argument is a list of sources

# Filter out false-positive promise chain errors.

# See https://github.com/google/closure-compiler/issues/715 for details.

« no previous file with comments | « no previous file | no next file » | no next file with comments »