Fix js checker script

third_party/closure_compiler/checker.py

 #!/usr/bin/python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs Closure compiler on a JavaScript file to check for errors."""
 
 import argparse
 import os
 import re
@@ skipping 222 matching lines @@
 
     includes = [rel_path(f) for f in depends + [source_file]]
     contents = ['<include src="%s">' % i for i in includes]
     meta_file = self._create_temp_file("\n".join(contents))
     self._debug("Meta file: %s" % meta_file)
 
     self._processor = processor.Processor(meta_file)
     self._expanded_file = self._create_temp_file(self._processor.contents)
     self._debug("Expanded file: %s" % self._expanded_file)
 
-    errors, stderr = self.run_js_check(self._expanded_file, depends)
+    errors, stderr = self.run_js_check([self._expanded_file], externs)

[Tyler Breisacher (Chromium), 2015/01/15 20:43:09]

run_js_check's first argument is a list of sources, not a single source. So why
wasn't this caught at compile time? Oh right.

/me wanders away grumbling about Python.

 
     # Filter out false-positive promise chain errors.
     # See https://github.com/google/closure-compiler/issues/715 for details.
     errors = self._error_filter.filter(errors);
 
     output = self._format_errors(map(self._fix_up_error, errors))
     if errors:
       prefix = "\n" if output else ""
       self._error("Error in: %s%s%s" % (source_file, prefix, output))
     elif output:
@@ skipping 62 matching lines @@
         open(opts.out_file, "w").write("")
   else:
     has_errors, errors = checker.check_multiple(opts.sources)
     if has_errors:
       print errors
       sys.exit(1)
 
   if opts.success_stamp:
     with open(opts.success_stamp, 'w'):
       os.utime(opts.success_stamp, None)