Cleanup dead code in base/ as found by Scythe.

Cleanup dead code in base/ as found by Scythe.

Some parts just needed to be ifdefed.

Committed: https://crrev.com/88c7b3339b207cd3424f5478b5e672485617ca44
Cr-Commit-Position: refs/heads/master@{#312576}

[Lei Zhang, 2015-01-20 22:42:22]

thestig@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-01-20 22:45:33]

nice!

https://codereview.chromium.org/853903003/diff/20001/base/i18n/i18n_constants.cc
File base/i18n/i18n_constants.cc (right):

https://codereview.chromium.org/853903003/diff/20001/base/i18n/i18n_constants...
base/i18n/i18n_constants.cc:13: const char kCodepageUTF16BE[] = "UTF-16BE";
likewise. we shouldn't have if 0 blocks checked in.

https://codereview.chromium.org/853903003/diff/20001/base/i18n/i18n_constants.h
File base/i18n/i18n_constants.h (right):

https://codereview.chromium.org/853903003/diff/20001/base/i18n/i18n_constants...
base/i18n/i18n_constants.h:16: // Not currently in use anywhere in the code
base.
delete, then?

[Lei Zhang, 2015-01-20 22:51:47]

https://codereview.chromium.org/853903003/diff/20001/base/i18n/i18n_constants.cc
File base/i18n/i18n_constants.cc (right):

https://codereview.chromium.org/853903003/diff/20001/base/i18n/i18n_constants...
base/i18n/i18n_constants.cc:13: const char kCodepageUTF16BE[] = "UTF-16BE";
On 2015/01/20 22:45:33, Nico wrote:
> likewise. we shouldn't have if 0 blocks checked in.

How about I add a comment?

// The other possible options are UTF-16BE and UTF-16LE, but they are unused in
Chromium as of this writing.

[Nico, 2015-01-20 22:54:06]

https://codereview.chromium.org/853903003/diff/20001/base/i18n/i18n_constants.cc
File base/i18n/i18n_constants.cc (right):

https://codereview.chromium.org/853903003/diff/20001/base/i18n/i18n_constants...
base/i18n/i18n_constants.cc:13: const char kCodepageUTF16BE[] = "UTF-16BE";
On 2015/01/20 22:51:46, Lei Zhang wrote:
> On 2015/01/20 22:45:33, Nico wrote:
> > likewise. we shouldn't have if 0 blocks checked in.
> 
> How about I add a comment?
> 
> // The other possible options are UTF-16BE and UTF-16LE, but they are unused
in
> Chromium as of this writing.

sgtm

[Lei Zhang, 2015-01-20 23:03:56]

https://codereview.chromium.org/853903003/diff/20001/base/i18n/i18n_constants.cc
File base/i18n/i18n_constants.cc (right):

https://codereview.chromium.org/853903003/diff/20001/base/i18n/i18n_constants...
base/i18n/i18n_constants.cc:13: const char kCodepageUTF16BE[] = "UTF-16BE";
On 2015/01/20 22:54:06, Nico wrote:
> On 2015/01/20 22:51:46, Lei Zhang wrote:
> > On 2015/01/20 22:45:33, Nico wrote:
> > > likewise. we shouldn't have if 0 blocks checked in.
> > 
> > How about I add a comment?
> > 
> > // The other possible options are UTF-16BE and UTF-16LE, but they are unused
> in
> > Chromium as of this writing.
> 
> sgtm

Done.

[Will Harris, 2015-01-20 23:04:47]

wfh@chromium.org changed reviewers:
+ wfh@chromium.org

[Will Harris, 2015-01-20 23:04:47]

https://codereview.chromium.org/853903003/diff/40001/base/message_loop/messag...
File base/message_loop/message_loop.cc (right):

https://codereview.chromium.org/853903003/diff/40001/base/message_loop/messag...
base/message_loop/message_loop.cc:120: #if defined(OS_WIN)
hi res timer is supported on platforms other than win...?

[Nico, 2015-01-20 23:05:44]

lgtm

[Lei Zhang, 2015-01-20 23:19:37]

https://codereview.chromium.org/853903003/diff/40001/base/message_loop/messag...
File base/message_loop/message_loop.cc (right):

https://codereview.chromium.org/853903003/diff/40001/base/message_loop/messag...
base/message_loop/message_loop.cc:120: #if defined(OS_WIN)
On 2015/01/20 23:04:47, Will Harris wrote:
> hi res timer is supported on platforms other than win...?

Doesn't look like it to me.

- The variables here are not used on any other platform.
- EnableHighResolutionTimer() and friends are all Windows-only in
base/time/time.h.

Am I missing something?

[Will Harris, 2015-01-20 23:21:26]

On 2015/01/20 23:19:37, Lei Zhang wrote:
>
https://codereview.chromium.org/853903003/diff/40001/base/message_loop/messag...
> File base/message_loop/message_loop.cc (right):
> 
>
https://codereview.chromium.org/853903003/diff/40001/base/message_loop/messag...
> base/message_loop/message_loop.cc:120: #if defined(OS_WIN)
> On 2015/01/20 23:04:47, Will Harris wrote:
> > hi res timer is supported on platforms other than win...?
> 
> Doesn't look like it to me.
> 
> - The variables here are not used on any other platform.
> - EnableHighResolutionTimer() and friends are all Windows-only in
> base/time/time.h.
> 
> Am I missing something?

sorry, I was reading the defines the wrong way round. ignore me. :)

[Will Harris, 2015-01-20 23:21:34]

wfh@chromium.org changed reviewers:
- wfh@chromium.org

[Lei Zhang, 2015-01-20 23:33:09]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-01-20 23:34:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/853903003/60001

[commit-bot: I haz the power, 2015-01-21 00:56:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-21 00:56:15]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2015-01-21 00:57:08]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-01-21 01:14:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/853903003/60001

[commit-bot: I haz the power, 2015-01-21 01:16:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-21 01:16:07]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2015-01-21 21:08:13]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-01-21 21:08:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/853903003/60001

[commit-bot: I haz the power, 2015-01-21 21:43:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-21 21:43:09]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Lei Zhang, 2015-01-21 21:45:05]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-01-21 21:46:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/853903003/60001

[commit-bot: I haz the power, 2015-01-21 22:09:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-21 22:09:44]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2015-01-21 22:28:02]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-01-21 22:29:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/853903003/60001

[commit-bot: I haz the power, 2015-01-21 22:30:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-21 22:30:08]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2015-01-21 23:28:40]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-01-21 23:30:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/853903003/60001

[commit-bot: I haz the power, 2015-01-22 00:09:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-22 00:09:06]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Lei Zhang, 2015-01-22 02:27:03]

I accidentally removed a bit too much code in patch set 4. Patch set 5 should be
good.

[Lei Zhang, 2015-01-22 02:27:08]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-01-22 02:28:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/853903003/80001

[commit-bot: I haz the power, 2015-01-22 02:38:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-22 02:38:31]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2015-01-22 06:13:41]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-01-22 06:14:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/853903003/80001

[commit-bot: I haz the power, 2015-01-22 07:10:18]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-01-22 07:11:10]

Patchset 5 (id:??) landed as
https://crrev.com/88c7b3339b207cd3424f5478b5e672485617ca44
Cr-Commit-Position: refs/heads/master@{#312576}