Make HyperlinkPreference optionally look like a link.

Make HyperlinkPreference optionally look like a link.

Use this option in AutofillWalletPreferences. We can also use this to simplify BandwidthReductionPreferences (which is where this code was mostly copied from), but that's in the internal repo, so is a different CL.

BUG=446700
Committed: https://crrev.com/e20555d490b11357f0f178783a6e180e82e17468
Cr-Commit-Position: refs/heads/master@{#311783}

[Evan Stade, 2015-01-15 18:24:03]

estade@chromium.org changed reviewers:
+ newt@chromium.org

[newt (away), 2015-01-15 18:40:47]

https://codereview.chromium.org/853863002/diff/1/chrome/android/java/res/valu...
File chrome/android/java/res/values/attrs.xml (right):

https://codereview.chromium.org/853863002/diff/1/chrome/android/java/res/valu...
chrome/android/java/res/values/attrs.xml:15: <attr name="immitateWebLink"
format="boolean" />
one "m" in imitate

https://codereview.chromium.org/853863002/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java
(right):

https://codereview.chromium.org/853863002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java:73:
if (mImmitateWebLink) {
Rather than using a span, you can simply set the text color and a click listener
on titleView.

[newt (away), 2015-01-15 18:41:58]

btw, I'm upstreaming the other uses of links in preferences, so don't bother
updating them downstream.

[Evan Stade, 2015-01-15 19:44:41]

https://codereview.chromium.org/853863002/diff/1/chrome/android/java/res/valu...
File chrome/android/java/res/values/attrs.xml (right):

https://codereview.chromium.org/853863002/diff/1/chrome/android/java/res/valu...
chrome/android/java/res/values/attrs.xml:15: <attr name="immitateWebLink"
format="boolean" />
On 2015/01/15 18:40:47, newt wrote:
> one "m" in imitate

back to grade school with me

https://codereview.chromium.org/853863002/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java
(right):

https://codereview.chromium.org/853863002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java:73:
if (mImmitateWebLink) {
On 2015/01/15 18:40:47, newt wrote:
> Rather than using a span, you can simply set the text color and a click
listener
> on titleView.

much simpler! done

[newt (away), 2015-01-15 19:48:05]

lgtm.

Thanks for unifying these!

[Evan Stade, 2015-01-15 20:06:12]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-15 20:07:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/853863002/20001

[commit-bot: I haz the power, 2015-01-15 20:44:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-15 20:44:58]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Evan Stade, 2015-01-15 21:04:57]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-15 21:06:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/853863002/20001

[commit-bot: I haz the power, 2015-01-15 21:06:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-15 21:06:50]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Evan Stade, 2015-01-15 23:28:46]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-15 23:29:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/853863002/20001

[commit-bot: I haz the power, 2015-01-16 00:39:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-16 00:40:15]

Patchset 2 (id:??) landed as
https://crrev.com/e20555d490b11357f0f178783a6e180e82e17468
Cr-Commit-Position: refs/heads/master@{#311783}