chrome/android/java/res/xml/autofill_wallet_preferences.xml - Issue 853863002: Make HyperlinkPreference optionally look like a link.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/xml/autofill_wallet_preferences.xml

Issue 853863002: Make HyperlinkPreference optionally look like a link. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: loc-- Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/values/attrs.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/xml/autofill_wallet_preferences.xml

diff --git a/chrome/android/java/res/xml/autofill_wallet_preferences.xml b/chrome/android/java/res/xml/autofill_wallet_preferences.xml

index 55f1b364d9edc1df342237eea99b445dd21211f7..c210391c7455e6f199ea94deb8848f8264fe1a5d 100644

--- a/chrome/android/java/res/xml/autofill_wallet_preferences.xml

+++ b/chrome/android/java/res/xml/autofill_wallet_preferences.xml

@@ -17,12 +17,10 @@

<org.chromium.chrome.browser.preferences.TextMessagePreference

android:title="@string/autofill_wallet_description" />

- <!-- TODO(estade): Surprisingly, HyperlinkPreference does not actually look like a link.

- We should either fix HyperlinkPreference or copy the technique used by

- data_reduction_learn_more. -->

<org.chromium.chrome.browser.preferences.HyperlinkPreference

android:title="@string/autofill_wallet_management_link_text"

- app:url="@string/autofill_manage_wallet_cards_url" />

+ app:url="@string/autofill_manage_wallet_cards_url"

+ app:imitateWebLink="true" />

<org.chromium.chrome.browser.preferences.TextMessagePreference

android:title="@string/autofill_wallet_cache_explanation" />