Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4924)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java

Issue 853863002: Make HyperlinkPreference optionally look like a link. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: loc-- Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/xml/autofill_wallet_preferences.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java
index 8bc6bde7aed47fd9bee3f512ef27aa7aa0524694..6c3f3037636f407cc475f0203c471b5a937e3dbc 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java
@@ -9,6 +9,7 @@ import android.content.res.TypedArray;
import android.preference.Preference;
import android.util.AttributeSet;
import android.view.View;
+import android.view.View.OnClickListener;
import android.widget.TextView;
import org.chromium.chrome.R;
@@ -20,12 +21,14 @@ public class HyperlinkPreference extends Preference {
private final int mTitleResId;
private final int mUrlResId;
+ private final boolean mImitateWebLink;
public HyperlinkPreference(Context context, AttributeSet attrs) {
super(context, attrs);
TypedArray a = context.obtainStyledAttributes(attrs,
R.styleable.HyperlinkPreference, 0, 0);
mUrlResId = a.getResourceId(R.styleable.HyperlinkPreference_url, 0);
+ mImitateWebLink = a.getBoolean(R.styleable.HyperlinkPreference_imitateWebLink, false);
a.recycle();
mTitleResId = getTitleRes();
}
@@ -40,5 +43,18 @@ public class HyperlinkPreference extends Preference {
super.onBindView(view);
TextView titleView = (TextView) view.findViewById(android.R.id.title);
titleView.setSingleLine(false);
+
+ if (mImitateWebLink) {
+ setSelectable(false);
+
+ titleView.setClickable(true);
+ titleView.setTextColor(titleView.getPaint().linkColor);
+ titleView.setOnClickListener(new OnClickListener() {
+ @Override
+ public void onClick(View v) {
+ HyperlinkPreference.this.onClick();
+ }
+ });
+ }
}
}
« no previous file with comments | « chrome/android/java/res/xml/autofill_wallet_preferences.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698