Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 853333002: Browser Plugin: Make aware of focus direction. (Closed)

Created:
5 years, 11 months ago by Fady Samuel
Modified:
5 years, 11 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Browser Plugin: Make aware of focus direction. In order to fix focus ordering into and out of GuestViews, this CL makes focus aware of tab direction. This CL is the content side change for this Blink change: https://codereview.chromium.org/852083002 BUG=448716, 147644 TBR=kenrb@chromium.org for trivial browser_plugin_messages.h change (added focus type to existing IPC). Committed: https://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07 Cr-Commit-Position: refs/heads/master@{#312126}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -38 lines) Patch
M components/plugins/renderer/webview_plugin.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/plugins/renderer/webview_plugin.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_embedder.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_embedder.cc View 5 chunks +4 lines, -4 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 4 chunks +7 lines, -6 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 3 chunks +14 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/browser_plugin/browser_plugin_messages.h View 3 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/npapi/webplugin_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Fady Samuel
+jochen@ for: components/plugins/renderer/webview_plugin.cc components/plugins/renderer/webview_plugin.h content/browser/DEPS content/browser/frame_host/render_widget_host_view_guest.cc content/common/DEPS content/renderer/npapi/webplugin_impl.cc content/renderer/npapi/webplugin_impl.h content/renderer/pepper/pepper_webplugin_impl.cc content/renderer/pepper/pepper_webplugin_impl.h +lfg@ for: browser_plugin +kenrb@ ...
5 years, 11 months ago (2015-01-17 12:02:08 UTC) #2
Fady Samuel
Jochen: This CL is the content side change for the Blink patch you reviewed: https://codereview.chromium.org/852083002
5 years, 11 months ago (2015-01-17 12:03:12 UTC) #3
lfg
On 2015/01/17 12:02:08, Fady Samuel wrote: > +lfg@ for: > > browser_plugin lgtm
5 years, 11 months ago (2015-01-18 20:23:19 UTC) #4
jochen (gone - plz use gerrit)
lgtm with nit https://codereview.chromium.org/853333002/diff/1/components/plugins/renderer/webview_plugin.cc File components/plugins/renderer/webview_plugin.cc (right): https://codereview.chromium.org/853333002/diff/1/components/plugins/renderer/webview_plugin.cc#newcode160 components/plugins/renderer/webview_plugin.cc:160: void WebViewPlugin::updateFocus(bool focused, blink::WebFocusType focusType) { ...
5 years, 11 months ago (2015-01-19 12:55:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853333002/20001
5 years, 11 months ago (2015-01-19 15:54:28 UTC) #7
kenrb
ipc lgtm
5 years, 11 months ago (2015-01-19 16:49:05 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-19 16:58:22 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 16:59:02 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5ec049ddf4a699a2fe3cf9531de78f91def7da07
Cr-Commit-Position: refs/heads/master@{#312126}

Powered by Google App Engine
This is Rietveld 408576698