Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 852083002: Propagate focus type to plugins (Closed)

Created:
5 years, 11 months ago by Fady Samuel
Modified:
5 years, 11 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Propagate focus type to plugins <webview> needs to be aware of tab direction so that it can set the appropriate initial focus. This issue is manifested in the Chrome signin-based which is now <webview> based. BUG=448716, 147644 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188535

Patch Set 1 #

Patch Set 2 : Compiles standalone #

Patch Set 3 : Compiles for real #

Patch Set 4 : Got rid of FocusType #

Patch Set 5 : Moved #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -293 lines) Patch
M Source/core/dom/Document.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/Element.h View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLabelElement.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLabelElement.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLegendElement.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLegendElement.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElement.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/InputTypeView.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/InputTypeView.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/TextFieldInputType.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TextFieldInputType.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/EmptyClients.h View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/Chrome.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/Chrome.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/ChromeClient.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/EventHandler.h View 1 2 3 4 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 3 5 chunks +11 lines, -11 lines 0 comments Download
M Source/core/page/FocusController.h View 1 2 3 4 4 chunks +14 lines, -14 lines 0 comments Download
M Source/core/page/FocusController.cpp View 1 2 3 18 chunks +34 lines, -34 lines 0 comments Download
D Source/core/page/FocusType.h View 1 2 3 1 chunk +0 lines, -50 lines 0 comments Download
M Source/core/page/SpatialNavigation.h View 1 2 3 4 3 chunks +13 lines, -13 lines 0 comments Download
M Source/core/page/SpatialNavigation.cpp View 1 2 3 25 chunks +80 lines, -80 lines 0 comments Download
M Source/core/svg/SVGAElement.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAElement.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/Widget.h View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M Source/web/ChromeClientImpl.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebPluginContainerImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + public/platform/WebFocusType.h View 1 2 3 4 1 chunk +21 lines, -12 lines 0 comments Download
M public/web/WebPlugin.h View 1 2 3 4 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
Fady Samuel
Hi Elliott, It seems like accessing core/page/FocusType.h in Source/Platform/* is a layering violation. Could you ...
5 years, 11 months ago (2015-01-14 21:54:46 UTC) #2
esprehn
On 2015/01/14 at 21:54:46, fsamuel wrote: > Hi Elliott, > > It seems like accessing ...
5 years, 11 months ago (2015-01-14 22:32:27 UTC) #3
Fady Samuel
On 2015/01/14 22:32:27, esprehn wrote: > On 2015/01/14 at 21:54:46, fsamuel wrote: > > Hi ...
5 years, 11 months ago (2015-01-14 22:56:33 UTC) #4
Fady Samuel
5 years, 11 months ago (2015-01-15 15:33:56 UTC) #6
jochen (gone - plz use gerrit)
can we use WebFocusType everywhere? (so you don't need macros to check that the casts ...
5 years, 11 months ago (2015-01-15 15:41:57 UTC) #7
Fady Samuel
PTAL
5 years, 11 months ago (2015-01-15 18:48:33 UTC) #8
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-16 10:47:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852083002/80001
5 years, 11 months ago (2015-01-16 12:02:01 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 13:26:25 UTC) #12
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188535

Powered by Google App Engine
This is Rietveld 408576698