content/renderer/browser_plugin/browser_plugin.h - Issue 853333002: Browser Plugin: Make aware of focus direction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 853333002: Browser Plugin: Make aware of focus direction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/browser_plugin/browser_plugin.h

diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h

index ed7b63b615a51b67637c262cd8bea595675b0c33..df8a1b94f7ea3bba74e7d5596628a0b06afa0aff 100644

--- a/content/renderer/browser_plugin/browser_plugin.h

+++ b/content/renderer/browser_plugin/browser_plugin.h

@@ -47,7 +47,7 @@ class CONTENT_EXPORT BrowserPlugin :

bool guest_crashed() const { return guest_crashed_; }

// Informs the guest of an updated focus state.

- void UpdateGuestFocusState();

+ void UpdateGuestFocusState(blink::WebFocusType focus_type);

// Indicates whether the guest should be focused.

bool ShouldGuestBeFocused() const;

@@ -92,7 +92,8 @@ class CONTENT_EXPORT BrowserPlugin :

const blink::WebRect& clip_rect,

const blink::WebVector<blink::WebRect>& cut_outs_rects,

bool is_visible) override;

- virtual void updateFocus(bool focused) override;

+ virtual void updateFocus(bool focused,

+ blink::WebFocusType focus_type) override;

virtual void updateVisibility(bool visible) override;

virtual bool acceptsInputEvents() override;

virtual bool handleInputEvent(