Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1479)

Unified Diff: Source/web/NotificationPresenterImpl.cpp

Issue 85263006: Make IDL Callbacks non-refcounted by default (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Patch for landing Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/NotificationPresenterImpl.h ('k') | Source/web/StorageQuotaChromium.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/NotificationPresenterImpl.cpp
diff --git a/Source/web/NotificationPresenterImpl.cpp b/Source/web/NotificationPresenterImpl.cpp
index 266a2cf67f3ae7c4a88555f8018ceea05a594e7c..43d3304afb90892f04d8a77be9c2730650a7a396 100644
--- a/Source/web/NotificationPresenterImpl.cpp
+++ b/Source/web/NotificationPresenterImpl.cpp
@@ -66,7 +66,7 @@ private:
class NotificationPermissionCallbackClient : public WebNotificationPermissionCallback {
public:
- NotificationPermissionCallbackClient(WebNotificationPresenter* presenter, PassRefPtr<SecurityOrigin> securityOrigin, PassRefPtr<NotificationPermissionCallback> callback)
+ NotificationPermissionCallbackClient(WebNotificationPresenter* presenter, PassRefPtr<SecurityOrigin> securityOrigin, PassOwnPtr<NotificationPermissionCallback> callback)
: m_presenter(presenter)
, m_securityOrigin(securityOrigin)
, m_callback(callback)
@@ -85,7 +85,7 @@ private:
WebNotificationPresenter* m_presenter;
RefPtr<SecurityOrigin> m_securityOrigin;
- RefPtr<NotificationPermissionCallback> m_callback;
+ OwnPtr<NotificationPermissionCallback> m_callback;
};
void NotificationPresenterImpl::initialize(WebNotificationPresenter* presenter)
@@ -130,7 +130,7 @@ void NotificationPresenterImpl::requestPermission(ExecutionContext* context, Pas
}
#endif // ENABLE(LEGACY_NOTIFICATIONS)
-void NotificationPresenterImpl::requestPermission(ExecutionContext* context, WTF::PassRefPtr<NotificationPermissionCallback> callback)
+void NotificationPresenterImpl::requestPermission(ExecutionContext* context, WTF::PassOwnPtr<NotificationPermissionCallback> callback)
{
m_presenter->requestPermission(WebSecurityOrigin(context->securityOrigin()), new NotificationPermissionCallbackClient(m_presenter, context->securityOrigin(), callback));
}
« no previous file with comments | « Source/web/NotificationPresenterImpl.h ('k') | Source/web/StorageQuotaChromium.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698