Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Side by Side Diff: Source/web/NotificationPresenterImpl.cpp

Issue 85263006: Make IDL Callbacks non-refcounted by default (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Patch for landing Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/NotificationPresenterImpl.h ('k') | Source/web/StorageQuotaChromium.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 59
60 private: 60 private:
61 virtual ~VoidCallbackClient() { } 61 virtual ~VoidCallbackClient() { }
62 62
63 RefPtr<VoidCallback> m_callback; 63 RefPtr<VoidCallback> m_callback;
64 }; 64 };
65 #endif // ENABLE(LEGACY_NOTIFICATIONS) 65 #endif // ENABLE(LEGACY_NOTIFICATIONS)
66 66
67 class NotificationPermissionCallbackClient : public WebNotificationPermissionCal lback { 67 class NotificationPermissionCallbackClient : public WebNotificationPermissionCal lback {
68 public: 68 public:
69 NotificationPermissionCallbackClient(WebNotificationPresenter* presenter, Pa ssRefPtr<SecurityOrigin> securityOrigin, PassRefPtr<NotificationPermissionCallba ck> callback) 69 NotificationPermissionCallbackClient(WebNotificationPresenter* presenter, Pa ssRefPtr<SecurityOrigin> securityOrigin, PassOwnPtr<NotificationPermissionCallba ck> callback)
70 : m_presenter(presenter) 70 : m_presenter(presenter)
71 , m_securityOrigin(securityOrigin) 71 , m_securityOrigin(securityOrigin)
72 , m_callback(callback) 72 , m_callback(callback)
73 { 73 {
74 } 74 }
75 75
76 virtual void permissionRequestComplete() 76 virtual void permissionRequestComplete()
77 { 77 {
78 if (m_callback) 78 if (m_callback)
79 m_callback->handleEvent(Notification::permissionString(static_cast<N otificationClient::Permission>(m_presenter->checkPermission(WebSecurityOrigin(m_ securityOrigin))))); 79 m_callback->handleEvent(Notification::permissionString(static_cast<N otificationClient::Permission>(m_presenter->checkPermission(WebSecurityOrigin(m_ securityOrigin)))));
80 delete this; 80 delete this;
81 } 81 }
82 82
83 private: 83 private:
84 virtual ~NotificationPermissionCallbackClient() { } 84 virtual ~NotificationPermissionCallbackClient() { }
85 85
86 WebNotificationPresenter* m_presenter; 86 WebNotificationPresenter* m_presenter;
87 RefPtr<SecurityOrigin> m_securityOrigin; 87 RefPtr<SecurityOrigin> m_securityOrigin;
88 RefPtr<NotificationPermissionCallback> m_callback; 88 OwnPtr<NotificationPermissionCallback> m_callback;
89 }; 89 };
90 90
91 void NotificationPresenterImpl::initialize(WebNotificationPresenter* presenter) 91 void NotificationPresenterImpl::initialize(WebNotificationPresenter* presenter)
92 { 92 {
93 m_presenter = presenter; 93 m_presenter = presenter;
94 } 94 }
95 95
96 bool NotificationPresenterImpl::isInitialized() 96 bool NotificationPresenterImpl::isInitialized()
97 { 97 {
98 return !!m_presenter; 98 return !!m_presenter;
(...skipping 24 matching lines...) Expand all
123 return static_cast<NotificationClient::Permission>(result); 123 return static_cast<NotificationClient::Permission>(result);
124 } 124 }
125 125
126 #if ENABLE(LEGACY_NOTIFICATIONS) 126 #if ENABLE(LEGACY_NOTIFICATIONS)
127 void NotificationPresenterImpl::requestPermission(ExecutionContext* context, Pas sRefPtr<VoidCallback> callback) 127 void NotificationPresenterImpl::requestPermission(ExecutionContext* context, Pas sRefPtr<VoidCallback> callback)
128 { 128 {
129 m_presenter->requestPermission(WebSecurityOrigin(context->securityOrigin()), new VoidCallbackClient(callback)); 129 m_presenter->requestPermission(WebSecurityOrigin(context->securityOrigin()), new VoidCallbackClient(callback));
130 } 130 }
131 #endif // ENABLE(LEGACY_NOTIFICATIONS) 131 #endif // ENABLE(LEGACY_NOTIFICATIONS)
132 132
133 void NotificationPresenterImpl::requestPermission(ExecutionContext* context, WTF ::PassRefPtr<NotificationPermissionCallback> callback) 133 void NotificationPresenterImpl::requestPermission(ExecutionContext* context, WTF ::PassOwnPtr<NotificationPermissionCallback> callback)
134 { 134 {
135 m_presenter->requestPermission(WebSecurityOrigin(context->securityOrigin()), new NotificationPermissionCallbackClient(m_presenter, context->securityOrigin() , callback)); 135 m_presenter->requestPermission(WebSecurityOrigin(context->securityOrigin()), new NotificationPermissionCallbackClient(m_presenter, context->securityOrigin() , callback));
136 } 136 }
137 137
138 } // namespace blink 138 } // namespace blink
OLDNEW
« no previous file with comments | « Source/web/NotificationPresenterImpl.h ('k') | Source/web/StorageQuotaChromium.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698