Source/web/NotificationPresenterImpl.h - Issue 85263006: Make IDL Callbacks non-refcounted by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/NotificationPresenterImpl.h

Issue 85263006: Make IDL Callbacks non-refcounted by default (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Patch for landing Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/NotificationPresenterImpl.h

diff --git a/Source/web/NotificationPresenterImpl.h b/Source/web/NotificationPresenterImpl.h

index e47223599d94585d0e09cb1b58ae7e20c0a76926..d1bbb7b1a7fcef159d2d819638be792581f60ddb 100644

--- a/Source/web/NotificationPresenterImpl.h

+++ b/Source/web/NotificationPresenterImpl.h

@@ -57,7 +57,7 @@ public:

#if ENABLE(LEGACY_NOTIFICATIONS)

virtual void requestPermission(WebCore::ExecutionContext*, WTF::PassRefPtr<WebCore::VoidCallback>);

#endif

- virtual void requestPermission(WebCore::ExecutionContext*, WTF::PassRefPtr<WebCore::NotificationPermissionCallback>);

+ virtual void requestPermission(WebCore::ExecutionContext*, WTF::PassOwnPtr<WebCore::NotificationPermissionCallback>);

virtual void cancelRequestsForPermission(WebCore::ExecutionContext*) { }

private: