LayoutTests/media/track/opera/interfaces/TrackEvent/constructor.html - Issue 85263002: Improve handling of dictionary conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/media/track/opera/interfaces/TrackEvent/constructor.html

Issue 85263002: Improve handling of dictionary conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have conversion methods take a context argument; elaborate error msgs further. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/events/constructors/wheel-event-constructor-expected.txt ('k') | LayoutTests/media/track/opera/interfaces/TrackEvent/constructor-expected.txt » ('j') | Source/bindings/v8/Dictionary.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/media/track/opera/interfaces/TrackEvent/constructor.html

diff --git a/LayoutTests/media/track/opera/interfaces/TrackEvent/constructor.html b/LayoutTests/media/track/opera/interfaces/TrackEvent/constructor.html

index 475cbfd690016de4f7c74fb68e3bec03bdef9a76..6369beb9685d364587571cd5bd1b333dde683b4f 100644

--- a/LayoutTests/media/track/opera/interfaces/TrackEvent/constructor.html

+++ b/LayoutTests/media/track/opera/interfaces/TrackEvent/constructor.html

@@ -14,11 +14,17 @@ test(function(){

}, document.title+', one arg');

test(function(){

var obj = {};

- var ev = new TrackEvent('foo', {track:obj});

+ try {

+ var ev = new TrackEvent('foo', {track:obj});

+ assert_unreached("Expected constructor to throw TypeError");

+ } catch (e) {

+ assert_true(e instanceof TypeError);

+ }

+ var ev = new TrackEvent('foo', {});

assert_true(ev instanceof TrackEvent, 'ev instanceof TrackEvent');

assert_true(ev instanceof Event, 'ev instanceof Event');

- assert_equals(ev.track, obj, 'ev.track');

+ assert_equals(ev.track, null, 'ev.track');

ev.track = {};

- assert_equals(ev.track, obj, 'ev.track after assignment');

+ assert_equals(ev.track, null, 'ev.track after assignment');

}, document.title+', two args');

-</script>

+</script>