Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: LayoutTests/fast/events/constructors/wheel-event-constructor-expected.txt

Issue 85263002: Improve handling of dictionary conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have conversion methods take a context argument; elaborate error msgs further. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/events/constructors/wheel-event-constructor-expected.txt
diff --git a/LayoutTests/fast/events/constructors/wheel-event-constructor-expected.txt b/LayoutTests/fast/events/constructors/wheel-event-constructor-expected.txt
index ece2bf7902d5c1b2aa2820e03568d961883b0abb..ef298bbb70661819f4dc9bb03966489adcb3dd91 100644
--- a/LayoutTests/fast/events/constructors/wheel-event-constructor-expected.txt
+++ b/LayoutTests/fast/events/constructors/wheel-event-constructor-expected.txt
@@ -26,19 +26,20 @@ PASS new WheelEvent('eventType', { cancelable: false }).cancelable is false
PASS new WheelEvent('eventType', { cancelable: true }).cancelable is true
PASS new WheelEvent('eventType', { view: window }).view is window
PASS new WheelEvent('eventType', { view: this }).view is this
-PASS new WheelEvent('eventType', { view: testObject }).view is null
-PASS new WheelEvent('eventType', { view: document }).view is null
+PASS new WheelEvent('eventType', { view: testObject }).view threw exception TypeError: Failed to construct 'WheelEvent': The 'view' property does not have a Window type..
+PASS new WheelEvent('eventType', { view: document }).view threw exception TypeError: Failed to construct 'WheelEvent': The 'view' property does not have a Window type..
PASS new WheelEvent('eventType', { view: undefined }).view is null
PASS new WheelEvent('eventType', { view: null }).view is null
-PASS new WheelEvent('eventType', { view: false }).view is null
-PASS new WheelEvent('eventType', { view: true }).view is null
-PASS new WheelEvent('eventType', { view: '' }).view is null
-PASS new WheelEvent('eventType', { view: 'chocolate' }).view is null
-PASS new WheelEvent('eventType', { view: 12345 }).view is null
-PASS new WheelEvent('eventType', { view: 18446744073709551615 }).view is null
-PASS new WheelEvent('eventType', { view: NaN }).view is null
-PASS new WheelEvent('eventType', { view: {valueOf: function () { return window; } } }).view == window is false
-PASS new WheelEvent('eventType', { get view() { return 123; } }).view is null
+PASS new WheelEvent('eventType', { view: false }).view threw exception TypeError: Failed to construct 'WheelEvent': The 'view' property does not have a Window type..
+PASS new WheelEvent('eventType', { view: true }).view threw exception TypeError: Failed to construct 'WheelEvent': The 'view' property does not have a Window type..
+PASS new WheelEvent('eventType', { view: '' }).view threw exception TypeError: Failed to construct 'WheelEvent': The 'view' property does not have a Window type..
+PASS new WheelEvent('eventType', { view: 'chocolate' }).view threw exception TypeError: Failed to construct 'WheelEvent': The 'view' property does not have a Window type..
+PASS new WheelEvent('eventType', { view: 12345 }).view threw exception TypeError: Failed to construct 'WheelEvent': The 'view' property does not have a Window type..
+PASS new WheelEvent('eventType', { view: 18446744073709551615 }).view threw exception TypeError: Failed to construct 'WheelEvent': The 'view' property does not have a Window type..
+PASS new WheelEvent('eventType', { view: NaN }).view threw exception TypeError: Failed to construct 'WheelEvent': The 'view' property does not have a Window type..
+PASS new WheelEvent('eventType', { view: {valueOf: function () { return window; } } }).view == window threw exception TypeError: Failed to construct 'WheelEvent': The 'view' property does not have a Window type..
+PASS new WheelEvent('eventType', { get view() { return window; } }).view is window
+PASS new WheelEvent('eventType', { get view() { return 123; } }).view threw exception TypeError: Failed to construct 'WheelEvent': The 'view' property does not have a Window type..
PASS new WheelEvent('eventType', { get view() { throw 'WheelEvent Error'; } }) threw exception WheelEvent Error.
PASS new WheelEvent('eventType', { detail: 0 }).detail is 0
PASS new WheelEvent('eventType', { detail: 2147483647 }).detail is 2147483647
@@ -245,18 +246,19 @@ PASS new WheelEvent('eventType', { button: {valueOf: function () { return 12345;
PASS new WheelEvent('eventType', { relatedTarget: testDiv }).relatedTarget is testDiv
PASS new WheelEvent('eventType', { relatedTarget: document }).relatedTarget is document
PASS new WheelEvent('eventType', { relatedTarget: xhr }).relatedTarget is xhr
-PASS new WheelEvent('eventType', { relatedTarget: testObject }).relatedTarget is null
+PASS new WheelEvent('eventType', { relatedTarget: testObject }).relatedTarget threw exception TypeError: Failed to construct 'WheelEvent': The 'relatedTarget' property does not have a EventTarget type..
PASS new WheelEvent('eventType', { relatedTarget: undefined }).relatedTarget is null
PASS new WheelEvent('eventType', { relatedTarget: null }).relatedTarget is null
-PASS new WheelEvent('eventType', { relatedTarget: false }).relatedTarget is null
-PASS new WheelEvent('eventType', { relatedTarget: true }).relatedTarget is null
-PASS new WheelEvent('eventType', { relatedTarget: '' }).relatedTarget is null
-PASS new WheelEvent('eventType', { relatedTarget: 'chocolate' }).relatedTarget is null
-PASS new WheelEvent('eventType', { relatedTarget: 12345 }).relatedTarget is null
-PASS new WheelEvent('eventType', { relatedTarget: 18446744073709551615 }).relatedTarget is null
-PASS new WheelEvent('eventType', { relatedTarget: NaN }).relatedTarget is null
-PASS new WheelEvent('eventType', { relatedTarget: {valueOf: function () { return testDiv; } } }).relatedTarget == testDiv is false
-PASS new WheelEvent('eventType', { get relatedTarget() { return 123; } }).relatedTarget is null
+PASS new WheelEvent('eventType', { relatedTarget: false }).relatedTarget threw exception TypeError: Failed to construct 'WheelEvent': The 'relatedTarget' property does not have a EventTarget type..
+PASS new WheelEvent('eventType', { relatedTarget: true }).relatedTarget threw exception TypeError: Failed to construct 'WheelEvent': The 'relatedTarget' property does not have a EventTarget type..
+PASS new WheelEvent('eventType', { relatedTarget: '' }).relatedTarget threw exception TypeError: Failed to construct 'WheelEvent': The 'relatedTarget' property does not have a EventTarget type..
+PASS new WheelEvent('eventType', { relatedTarget: 'chocolate' }).relatedTarget threw exception TypeError: Failed to construct 'WheelEvent': The 'relatedTarget' property does not have a EventTarget type..
+PASS new WheelEvent('eventType', { relatedTarget: 12345 }).relatedTarget threw exception TypeError: Failed to construct 'WheelEvent': The 'relatedTarget' property does not have a EventTarget type..
+PASS new WheelEvent('eventType', { relatedTarget: 18446744073709551615 }).relatedTarget threw exception TypeError: Failed to construct 'WheelEvent': The 'relatedTarget' property does not have a EventTarget type..
+PASS new WheelEvent('eventType', { relatedTarget: NaN }).relatedTarget threw exception TypeError: Failed to construct 'WheelEvent': The 'relatedTarget' property does not have a EventTarget type..
+PASS new WheelEvent('eventType', { relatedTarget: {valueOf: function () { return testDiv; } } }).relatedTarget == testDiv threw exception TypeError: Failed to construct 'WheelEvent': The 'relatedTarget' property does not have a EventTarget type..
+PASS new WheelEvent('eventType', { get relatedTarget() { return testDiv; } }).relatedTarget is testDiv
+PASS new WheelEvent('eventType', { get relatedTarget() { return 123; } }).relatedTarget threw exception TypeError: Failed to construct 'WheelEvent': The 'relatedTarget' property does not have a EventTarget type..
PASS new WheelEvent('eventType', { get relatedTarget() { throw 'WheelEvent Error'; } }) threw exception WheelEvent Error.
PASS new WheelEvent('eventType', { bubbles: true, cancelable: true, view: window, detail: 111, screenX: 222, screenY: 333, clientX: 444, clientY: 555, ctrlKey: true, shiftKey: true, altKey: true, metaKey: true, button: 666, relatedTarget: testDiv, wheelDeltaX: 777, wheelDeltaY: 888, deltaMode: WheelEvent.DOM_DELTA_PAGE }).bubbles is true
PASS new WheelEvent('eventType', { bubbles: true, cancelable: true, view: window, detail: 111, screenX: 222, screenY: 333, clientX: 444, clientY: 555, ctrlKey: true, shiftKey: true, altKey: true, metaKey: true, button: 666, relatedTarget: testDiv, wheelDeltaX: 777, wheelDeltaY: 888, deltaMode: WheelEvent.DOM_DELTA_PAGE }).cancelable is true

Powered by Google App Engine
This is Rietveld 408576698